<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13369">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_l1_if: Fix erroneous endian-swapping of the CellID<br><br>In Change-Id I787fed84a7b613158a5618dd5cffafe4e4927234 in February 2018<br>we accidentially introduced a change that would erroneously swap<br>the endianness of the CellID on the way between PCUIF socket and<br>BSGSP.  This meant that all OsmoPCU based BTSs would report the<br>wrong CellId to the SGSN.<br><br>Closes: OS#3854<br>Change-Id: I2f6cc930c5dbf8dac386b24b0756df2efe8199e4<br>---<br>M src/pcu_l1_if.cpp<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/69/13369/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp</span><br><span>index 27e86dd..b59f198 100644</span><br><span>--- a/src/pcu_l1_if.cpp</span><br><span>+++ b/src/pcu_l1_if.cpp</span><br><span>@@ -414,7 +414,6 @@</span><br><span>      int rc = 0;</span><br><span>  unsigned int trx, ts;</span><br><span>        int i;</span><br><span style="color: hsl(0, 100%, 40%);">-  uint16_t cell_id = ntohs(info_ind->cell_id);</span><br><span> </span><br><span>  if (info_ind->version != PCU_IF_VERSION) {</span><br><span>                fprintf(stderr, "PCU interface version number of BTS (%d) is "</span><br><span>@@ -445,7 +444,7 @@</span><br><span>       LOGP(DL1IF, LOGL_DEBUG, " mnc=%0*u\n", info_ind->mnc_3_digits, info_ind->mnc);</span><br><span>       LOGP(DL1IF, LOGL_DEBUG, " lac=%d\n", info_ind->lac);</span><br><span>    LOGP(DL1IF, LOGL_DEBUG, " rac=%d\n", info_ind->rac);</span><br><span style="color: hsl(0, 100%, 40%);">-       LOGP(DL1IF, LOGL_DEBUG, " cell_id=%d\n", cell_id);</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DL1IF, LOGL_DEBUG, " cell_id=%d\n", info_ind->cell_id);</span><br><span>    LOGP(DL1IF, LOGL_DEBUG, " bsic=%d\n", info_ind->bsic);</span><br><span>  LOGP(DL1IF, LOGL_DEBUG, " nsei=%d\n", info_ind->nsei);</span><br><span>  LOGP(DL1IF, LOGL_DEBUG, " nse_timer=%d %d %d %d %d %d %d\n",</span><br><span>@@ -496,7 +495,7 @@</span><br><span>                 info_ind->remote_ip[0], info_ind->remote_port[0],</span><br><span>              info_ind->nsei, info_ind->nsvci[0], info_ind->bvci,</span><br><span>                 info_ind->mcc, info_ind->mnc, info_ind->mnc_3_digits, info_ind->lac, info_ind->rac,</span><br><span style="color: hsl(0, 100%, 40%);">-              cell_id);</span><br><span style="color: hsl(120, 100%, 40%);">+             info_ind->cell_id);</span><br><span>       if (!pcu) {</span><br><span>          LOGP(DL1IF, LOGL_NOTICE, "SGSN not available\n");</span><br><span>          goto bssgp_failed;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13369">change 13369</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13369"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2f6cc930c5dbf8dac386b24b0756df2efe8199e4 </div>
<div style="display:none"> Gerrit-Change-Number: 13369 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>