<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13298">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Constify pcu_rx_*() parameters<br><br>Use const for data parameter where appropriate.<br><br>Change-Id: Ia228c001ca07cfde61b540bec6257b62aec93517<br>---<br>M include/osmo-bts/l1sap.h<br>M src/common/l1sap.c<br>M src/common/pcu_sock.c<br>3 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/98/13298/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h</span><br><span>index 3cf0ea5..70b4564 100644</span><br><span>--- a/include/osmo-bts/l1sap.h</span><br><span>+++ b/include/osmo-bts/l1sap.h</span><br><span>@@ -71,7 +71,7 @@</span><br><span> </span><br><span> /* pcu (socket interface) sends us a data request primitive */</span><br><span> int l1sap_pdch_req(struct gsm_bts_trx_ts *ts, int is_ptcch, uint32_t fn,</span><br><span style="color: hsl(0, 100%, 40%);">-        uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len);</span><br><span style="color: hsl(120, 100%, 40%);">+        uint16_t arfcn, uint8_t block_nr, const uint8_t *data, uint8_t len);</span><br><span> </span><br><span> /* call-back function for incoming RTP */</span><br><span> void l1sap_rtp_rx_cb(struct osmo_rtp_socket *rs, const uint8_t *rtp_pl,</span><br><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index dba08df..a1b0464 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1388,7 +1388,7 @@</span><br><span> </span><br><span> /* pcu (socket interface) sends us a data request primitive */</span><br><span> int l1sap_pdch_req(struct gsm_bts_trx_ts *ts, int is_ptcch, uint32_t fn,</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len)</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t arfcn, uint8_t block_nr, const uint8_t *data, uint8_t len)</span><br><span> {</span><br><span>     struct msgb *msg;</span><br><span>    struct osmo_phsap_prim *l1sap;</span><br><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index 60e0f7a..2c7028e 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -466,7 +466,7 @@</span><br><span> }</span><br><span> </span><br><span> static int pcu_rx_data_req(struct gsm_bts *bts, uint8_t msg_type,</span><br><span style="color: hsl(0, 100%, 40%);">-     struct gsm_pcu_if_data *data_req)</span><br><span style="color: hsl(120, 100%, 40%);">+     const struct gsm_pcu_if_data *data_req)</span><br><span> {</span><br><span>         uint8_t is_ptcch;</span><br><span>    struct gsm_bts_trx *trx;</span><br><span>@@ -538,7 +538,7 @@</span><br><span> }</span><br><span> </span><br><span> static int pcu_rx_pag_req(struct gsm_bts *bts, uint8_t msg_type,</span><br><span style="color: hsl(0, 100%, 40%);">-     struct gsm_pcu_if_pag_req *pag_req)</span><br><span style="color: hsl(120, 100%, 40%);">+   const struct gsm_pcu_if_pag_req *pag_req)</span><br><span> {</span><br><span>       int rc = 0;</span><br><span> </span><br><span>@@ -598,7 +598,7 @@</span><br><span> }</span><br><span> </span><br><span> static int pcu_rx_act_req(struct gsm_bts *bts,</span><br><span style="color: hsl(0, 100%, 40%);">-        struct gsm_pcu_if_act_req *act_req)</span><br><span style="color: hsl(120, 100%, 40%);">+   const struct gsm_pcu_if_act_req *act_req)</span><br><span> {</span><br><span>       struct gsm_bts_trx *trx;</span><br><span>     struct gsm_lchan *lchan;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13298">change 13298</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13298"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia228c001ca07cfde61b540bec6257b62aec93517 </div>
<div style="display:none"> Gerrit-Change-Number: 13298 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>