<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13234">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Max: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Store + show remote ip/port in dynamically created ASPs<br><br>"show cs7 instance 0 asp" before this patch would not display the<br>remote IP/port information about dynamically-added ASPs but instead:<br><br> Effect Primary<br><br>ASP Name AS Name State Type Rmt Port Remote IP Addr SCTP<br>------------ ------------ ------------- ---- -------- --------------- ----------<br>asp-dyn-0 ? ASP_ACTIVE m3ua 0 (null)<br><br>With this patch it is now correctly displayed:<br> Effect Primary<br><br>ASP Name AS Name State Type Rmt Port Remote IP Addr SCTP<br>------------ ------------ ------------- ---- -------- --------------- ----------<br>asp-dyn-0 ? ASP_ACTIVE m3ua 24905 127.0.0.1<br><br>Change-Id: I39a1c57bc72e8aff607f3a551811a2f6372adab4<br>Closes: OS#3836<br>---<br>M src/osmo_ss7.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 381a53a..f8633b6 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -1691,9 +1691,15 @@</span><br><span> asp = osmo_ss7_asp_find_or_create(oxs->inst, namebuf, 0, 0,</span><br><span> oxs->cfg.proto);</span><br><span> if (asp) {</span><br><span style="color: hsl(120, 100%, 40%);">+ char hostbuf[INET6_ADDRSTRLEN];</span><br><span style="color: hsl(120, 100%, 40%);">+ char portbuf[16];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_sock_get_ip_and_port(fd, hostbuf, sizeof(hostbuf), portbuf, sizeof(portbuf), false);</span><br><span> LOGP(DLSS7, LOGL_INFO, "%s: created dynamicASP %s\n",</span><br><span> sock_name, asp->cfg.name);</span><br><span> asp->cfg.is_server = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ asp->cfg.remote.port = atoi(portbuf);</span><br><span style="color: hsl(120, 100%, 40%);">+ asp->cfg.remote.host = talloc_strdup(asp, hostbuf);</span><br><span> asp->dyn_allocated = true;</span><br><span> asp->server = srv;</span><br><span> osmo_ss7_asp_restart(asp);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13234">change 13234</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13234"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I39a1c57bc72e8aff607f3a551811a2f6372adab4 </div>
<div style="display:none"> Gerrit-Change-Number: 13234 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>