<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13243">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">TBF: update MCS counters<br><br>* use enum CodingScheme directly instead of converting it to class and<br> back<br>* drop useless mode check<br>* log errorneous update attempt<br><br>Change-Id: I763136c2f356d63aa3d28d09c57fd5faf5336258<br>---<br>M src/tbf.h<br>M src/tbf_dl.cpp<br>M src/tbf_ul.cpp<br>3 files changed, 116 insertions(+), 126 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/43/13243/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.h b/src/tbf.h</span><br><span>index dc0b050..0a58862 100644</span><br><span>--- a/src/tbf.h</span><br><span>+++ b/src/tbf.h</span><br><span>@@ -648,7 +648,7 @@</span><br><span> int abort();</span><br><span> uint16_t window_size() const;</span><br><span> void set_window_size();</span><br><span style="color: hsl(0, 100%, 40%);">- void update_coding_scheme_counter_dl(const GprsCodingScheme cs);</span><br><span style="color: hsl(120, 100%, 40%);">+ void update_coding_scheme_counter_dl(enum CodingScheme cs);</span><br><span> </span><br><span> /* TODO: add the gettimeofday as parameter */</span><br><span> struct msgb *llc_dequeue(bssgp_bvc_ctx *bctx);</span><br><span>@@ -751,7 +751,7 @@</span><br><span> </span><br><span> uint16_t window_size() const;</span><br><span> void set_window_size();</span><br><span style="color: hsl(0, 100%, 40%);">- void update_coding_scheme_counter_ul(const GprsCodingScheme cs);</span><br><span style="color: hsl(120, 100%, 40%);">+ void update_coding_scheme_counter_ul(enum CodingScheme cs);</span><br><span> </span><br><span> /* Please note that all variables here will be reset when changing</span><br><span> * from WAIT RELEASE back to FLOW state (re-use of TBF).</span><br><span>diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp</span><br><span>index 13ef143..04c6499 100644</span><br><span>--- a/src/tbf_dl.cpp</span><br><span>+++ b/src/tbf_dl.cpp</span><br><span>@@ -1364,68 +1364,63 @@</span><br><span> m_window.set_ws(ws);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void gprs_rlcmac_dl_tbf::update_coding_scheme_counter_dl(const GprsCodingScheme cs)</span><br><span style="color: hsl(120, 100%, 40%);">+void gprs_rlcmac_dl_tbf::update_coding_scheme_counter_dl(enum CodingScheme cs)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t coding_scheme = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- coding_scheme = CodingScheme(cs);</span><br><span style="color: hsl(0, 100%, 40%);">- if (mcs_is_gprs(cs)) {</span><br><span style="color: hsl(0, 100%, 40%);">- switch (coding_scheme) {</span><br><span style="color: hsl(0, 100%, 40%);">- case CS1 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_dl_cs1();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS1]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case CS2 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_dl_cs2();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS2]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case CS3 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_dl_cs3();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS3]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case CS4 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_dl_cs4();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS4]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- switch (coding_scheme) {</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS1 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs1();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS1]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS2 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs2();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS2]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS3 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs3();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS3]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS4 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs4();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS4]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS5 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs5();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS5]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS6 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs6();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS6]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS7 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs7();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS7]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS8 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs8();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS8]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS9 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_dl_mcs9();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS9]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (cs) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS1:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_dl_cs1();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS2:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_dl_cs2();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS2]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS3:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_dl_cs3();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS3]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS4:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_dl_cs4();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_gprs_ctrs->ctr[TBF_CTR_GPRS_DL_CS4]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS1:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs1();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS2:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs2();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS2]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS3:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs3();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS3]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS4:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs4();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS4]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS5:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs5();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS5]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS6:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs6();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS6]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS7:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs7();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS7]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS8:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs8();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS8]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS9:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_dl_mcs9();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_dl_egprs_ctrs->ctr[TBF_CTR_EGPRS_DL_MCS9]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTBFDL(this, LOGL_ERROR, "attempting to update rate counters for unsupported (M)CS %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ mcs_name(cs));</span><br><span> }</span><br><span> }</span><br><span>diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp</span><br><span>index f40ec3d..fd7d73b 100644</span><br><span>--- a/src/tbf_ul.cpp</span><br><span>+++ b/src/tbf_ul.cpp</span><br><span>@@ -525,69 +525,64 @@</span><br><span> return assemble_status;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void gprs_rlcmac_ul_tbf::update_coding_scheme_counter_ul(const GprsCodingScheme cs)</span><br><span style="color: hsl(120, 100%, 40%);">+void gprs_rlcmac_ul_tbf::update_coding_scheme_counter_ul(enum CodingScheme cs)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t coding_scheme = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- coding_scheme = CodingScheme(cs);</span><br><span style="color: hsl(0, 100%, 40%);">- if (mcs_is_gprs(cs)) {</span><br><span style="color: hsl(0, 100%, 40%);">- switch (coding_scheme) {</span><br><span style="color: hsl(0, 100%, 40%);">- case CS1 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_ul_cs1();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS1]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case CS2 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_ul_cs2();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS2]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case CS3 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_ul_cs3();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS3]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case CS4 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->gprs_ul_cs4();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS4]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- switch (coding_scheme) {</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS1 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs1();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS1]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS2 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs2();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS2]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS3 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs3();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS3]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS4 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs4();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS4]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS5 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs5();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS5]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS6 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs6();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS6]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS7 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs7();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS7]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS8 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs8();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS8]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case MCS9 :</span><br><span style="color: hsl(0, 100%, 40%);">- bts->egprs_ul_mcs9();</span><br><span style="color: hsl(0, 100%, 40%);">- rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS9]);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (cs) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS1:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_ul_cs1();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS2:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_ul_cs2();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS2]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS3:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_ul_cs3();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS3]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case CS4:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->gprs_ul_cs4();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_gprs_ctrs->ctr[TBF_CTR_GPRS_UL_CS4]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS1:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs1();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS2:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs2();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS2]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS3:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs3();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS3]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS4:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs4();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS4]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS5:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs5();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS5]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS6:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs6();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS6]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS7:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs7();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS7]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS8:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs8();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS8]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case MCS9:</span><br><span style="color: hsl(120, 100%, 40%);">+ bts->egprs_ul_mcs9();</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc(&m_ul_egprs_ctrs->ctr[TBF_CTR_EGPRS_UL_MCS9]);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTBFUL(this, LOGL_ERROR, "attempting to update rate counters for unsupported (M)CS %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ mcs_name(cs));</span><br><span> }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13243">change 13243</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13243"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I763136c2f356d63aa3d28d09c57fd5faf5336258 </div>
<div style="display:none"> Gerrit-Change-Number: 13243 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>