<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13229">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">improve logging for rejected AS in xua_rkm.c<br><br>Change a loglevel from NOTICE to ERROR, for when a routing key gets<br>re-purposed.<br><br>Add another error log for insufficient resources case.<br><br>Change-Id: Id22e3c6bab5f7b597df3514eedb162277ce0ef7d<br>---<br>M src/xua_rkm.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/29/13229/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/xua_rkm.c b/src/xua_rkm.c</span><br><span>index a77460d..4b760ee 100644</span><br><span>--- a/src/xua_rkm.c</span><br><span>+++ b/src/xua_rkm.c</span><br><span>@@ -214,7 +214,7 @@</span><br><span>     if (as) {</span><br><span>            LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: Found existing AS for RCTX %u\n", rctx);</span><br><span>            if (as->cfg.routing_key.pc != dpc) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: DPC doesn't match (%u != %u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                 LOGPASP(asp, DLSS7, LOGL_ERROR, "RKM: DPC doesn't match, rejecting AS (%u != %u)\n",</span><br><span>                           as->cfg.routing_key.pc, dpc);</span><br><span>                     msgb_append_reg_res(resp, rk_id, M3UA_RKM_REG_ERR_INVAL_RKEY, 0);</span><br><span>                    return -1;</span><br><span>@@ -250,6 +250,8 @@</span><br><span>             if (*nas_idx >= max_nas_idx) {</span><br><span>                    osmo_ss7_route_destroy(rt);</span><br><span>                  osmo_ss7_as_destroy(as);</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGPASP(asp, DLSS7, LOGL_ERROR, "RKM: not enough room for newly assigned AS (max %u AS)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                         max_nas_idx+1);</span><br><span>                      msgb_append_reg_res(resp, rk_id, M3UA_RKM_REG_ERR_INSUFF_RESRC, 0);</span><br><span>                  return -1;</span><br><span>           }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13229">change 13229</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13229"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id22e3c6bab5f7b597df3514eedb162277ce0ef7d </div>
<div style="display:none"> Gerrit-Change-Number: 13229 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>