<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13174">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
Vadim Yanitskiy: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: add cmd subscriber ID sms delete-all<br><br>In ttcn3-msc-tests, so far we leave an intentionally failed MT SMS in the SMS<br>queue, which may cause it to re-appear in subsequent tests.<br><br>Allow removing all SMS for a given subscriber from the SMS database for good.<br><br>(I dimly remember a user report where the SMS queue spams failed SMS attempts,<br>and the only way to get rid of SMS for a given subscriber is to tamper with the<br>sms.db file directly. This should no longer be necessary with this command.)<br><br>Related: I7dce12942a65eaaf97f78ca69401c7f93faacb9e (osmo-ttcn3-hacks)<br>Change-Id: I637cbd7adc075a192f49752b38779391472ff06d<br>---<br>M src/libmsc/msc_vty.c<br>1 file changed, 25 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index 2adb2a4..ac3946a 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -959,6 +959,30 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(subscriber_sms_delete_all,</span><br><span style="color: hsl(120, 100%, 40%);">+ subscriber_sms_delete_all_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "subscriber " SUBSCR_TYPES " ID sms delete-all",</span><br><span style="color: hsl(120, 100%, 40%);">+ SUBSCR_HELP "SMS Operations\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Delete all SMS to be delivered to this subscriber"</span><br><span style="color: hsl(120, 100%, 40%);">+ " -- WARNING: the SMS data for all unsent SMS for this subscriber"</span><br><span style="color: hsl(120, 100%, 40%);">+ " WILL BE LOST.\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct vlr_subscr *vsub;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vsub = get_vsub_by_argv(gsmnet, argv[0], argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!vsub) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%% No subscriber found for %s %s%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ argv[0], argv[1], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ db_sms_delete_by_msisdn(vsub->msisdn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vlr_subscr_put(vsub);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(subscriber_send_sms,</span><br><span> subscriber_send_sms_cmd,</span><br><span> "subscriber " SUBSCR_TYPES " ID sms sender " SUBSCR_TYPES " SENDER_ID send .LINE",</span><br><span>@@ -1651,6 +1675,7 @@</span><br><span> install_element(ENABLE_NODE, &smsqueue_clear_cmd);</span><br><span> install_element(ENABLE_NODE, &smsqueue_fail_cmd);</span><br><span> install_element(ENABLE_NODE, &subscriber_send_pending_sms_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(ENABLE_NODE, &subscriber_sms_delete_all_cmd);</span><br><span> </span><br><span> install_element(CONFIG_NODE, &cfg_mncc_int_cmd);</span><br><span> install_node(&mncc_int_node, config_write_mncc_int);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13174">change 13174</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13174"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I637cbd7adc075a192f49752b38779391472ff06d </div>
<div style="display:none"> Gerrit-Change-Number: 13174 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>