<p><a href="https://gerrit.osmocom.org/13196">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c">File src/input/ipa_keepalive.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c@126">Patch Set #2, Line 126:</a> <code style="font-family:monospace,monospace">                                       ifp->params.wait_for_resp, T_SEND_NEXT_PING);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Are params correct or actually swapped? shouldn't be here ifp->params.interval and in ipa_ka_init ifp->params.wait_for_resp?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13196/2/src/input/ipa_keepalive.c@214">Patch Set #2, Line 214:</a> <code style="font-family:monospace,monospace">   fi = osmo_fsm_inst_alloc(&ipa_keepalive_fsm, ctx, NULL, LOGL_DEBUG, id);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">check against NULL and return</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13196">change 13196</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13196"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2763da49a74de85046ac07d53592c89973314ca6 </div>
<div style="display:none"> Gerrit-Change-Number: 13196 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 08 Mar 2019 22:46:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>