<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13192">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: expect only one Paging on failed MT SMS, and clear the failed SMS<br><br>An MSC should not repeat Paging Requests to the BSC. Retries of Paging are<br>clearly the task of the BSC.<br><br>The reason current osmo-msc sends so many Pagings for a single failed SMS is a<br>quirk in the sms_queue.c code.<br><br>An sms_queue.c fix that will make this change pass is in osmo-msc<br>I24bf9f1c1167efe1080ae4cf47ed2ef0bd981e49<br><br>After this quirk is fixed, the failed SMS attempts are not exhausted, and the<br>pending SMS will re-appear in subsequent tests, breaking their flow (e.g.<br>during subsequent Location Updating, an unexpected DTAP comes up). For this<br>reason, we need to actually remove the SMS from the SMS database and the queue<br>with a new VTY command: The vty command to clear failed SMS from the db follows<br>in osmo-msc I637cbd7adc075a192f49752b38779391472ff06d<br><br>Depends: I24bf9f1c1167efe1080ae4cf47ed2ef0bd981e49 (osmo-msc)<br> I637cbd7adc075a192f49752b38779391472ff06d (osmo-msc)<br>Change-Id: I7dce12942a65eaaf97f78ca69401c7f93faacb9e<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 17 insertions(+), 37 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/13192/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 31a7401..2957e3c 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -1979,6 +1979,13 @@</span><br><span> f_vty_transceive(MSCVTY, "subscriber imsi "&imsi&" sms sender msisdn "&msisdn&" send "&text);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Remove still pending SMS */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_vty_sms_clear(charstring imsi)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(MSCVTY, "subscriber imsi " & imsi & " sms delete-all");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(MSCVTY, "sms-queue clear");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* LU followed by MT SMS */</span><br><span> private function f_tc_lu_and_mt_sms(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span> var SmsParameters spars := valueof(t_SmsPars);</span><br><span>@@ -2022,7 +2029,6 @@</span><br><span> private function f_tc_lu_and_mt_sms_paging_and_nothing(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span> var SmsParameters spars := valueof(t_SmsPars);</span><br><span> var OCT4 tmsi;</span><br><span style="color: hsl(0, 100%, 40%);">- var integer page_count := 0;</span><br><span> f_init_handler(pars, 150.0);</span><br><span> </span><br><span> /* Perform location update */</span><br><span>@@ -2038,21 +2044,8 @@</span><br><span> </span><br><span> f_vty_sms_send(hex2str(pars.imsi), "2342", "Hello SMS");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Expect the MSC to page exactly 10 times before giving up */</span><br><span style="color: hsl(0, 100%, 40%);">- alt {</span><br><span style="color: hsl(0, 100%, 40%);">- [] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi))</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- page_count := page_count + 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (page_count < 10) {</span><br><span style="color: hsl(0, 100%, 40%);">- repeat;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- [] BSSAP.receive {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "unexpected BSSAP message received");</span><br><span style="color: hsl(0, 100%, 40%);">- self.stop;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect the MSC to page exactly once */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) { };</span><br><span> </span><br><span> /* Wait some time to make sure the MSC is not delivering any further</span><br><span> * paging messages or anything else that could be unexpected. */</span><br><span>@@ -2073,6 +2066,8 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_sms_clear(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> testcase TC_lu_and_mt_sms_paging_and_nothing() runs on MTC_CT {</span><br><span>@@ -4331,21 +4326,8 @@</span><br><span> /* Trigger SMS via VTY */</span><br><span> f_vty_sms_send_conn_hdlr(hex2str(pars.imsi), "2342", "Hello SMS");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Expect the MSC/VLR to page exactly 10 times before giving up */</span><br><span style="color: hsl(0, 100%, 40%);">- alt {</span><br><span style="color: hsl(0, 100%, 40%);">- [] SGsAP.receive(exp_pag_req)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- page_count := page_count + 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (page_count < 10) {</span><br><span style="color: hsl(0, 100%, 40%);">- repeat;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- [] SGsAP.receive {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "unexpected SGsAP message received");</span><br><span style="color: hsl(0, 100%, 40%);">- self.stop;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect the MSC/VLR to page exactly once */</span><br><span style="color: hsl(120, 100%, 40%);">+ SGsAP.receive(exp_pag_req);</span><br><span> </span><br><span> /* Wait some time to make sure the MSC is not delivering any further</span><br><span> * paging messages or anything else that could be unexpected. */</span><br><span>@@ -4373,8 +4355,8 @@</span><br><span> * MSC/VLR would re-try to deliver the test SMS trigered above and</span><br><span> * so the screening would fail. */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Expire the subscriber now to avoid that the MSC will try the SMS</span><br><span style="color: hsl(0, 100%, 40%);">- * delivery at some later point. */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_sms_clear(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> f_vty_transceive(MSCVTY, "subscriber imsi " & hex2str(g_pars.imsi) & " expire");</span><br><span> </span><br><span> setverdict(pass);</span><br><span>@@ -4429,16 +4411,14 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_sms_clear(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* A rejected paging with IMSI_unknown (see above) should always send</span><br><span> * the SGs association to NULL. */</span><br><span> f_ctrl_get_exp(IPA_CTRL, "fsm.SGs-UE.id.imsi:" & hex2str(g_pars.imsi) & ".state", "SGs-NULL");</span><br><span> </span><br><span> f_sgsap_bssmap_screening();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Expire the subscriber now to avoid that the MSC will try the SMS</span><br><span style="color: hsl(0, 100%, 40%);">- * delivery at some later point. */</span><br><span style="color: hsl(0, 100%, 40%);">- f_vty_transceive(MSCVTY, "subscriber imsi " & hex2str(g_pars.imsi) & " expire");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> testcase TC_sgsap_mt_sms_and_reject() runs on MTC_CT {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13192">change 13192</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13192"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7dce12942a65eaaf97f78ca69401c7f93faacb9e </div>
<div style="display:none"> Gerrit-Change-Number: 13192 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>