<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13165">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Enable LGLOBAL logging for TBF tests<br><br>This exposes the bug in BSSGP rate counter group allocation in the<br>current tests version which should be fixed in a separate commit.<br><br>Change-Id: I6317eccfb1408c5c9d07110a8b059f5ceb5d2afc<br>---<br>M tests/tbf/TbfTest.cpp<br>M tests/tbf/TbfTest.err<br>2 files changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp</span><br><span>index ff73d90..d78a4ab 100644</span><br><span>--- a/tests/tbf/TbfTest.cpp</span><br><span>+++ b/tests/tbf/TbfTest.cpp</span><br><span>@@ -3262,7 +3262,7 @@</span><br><span> bssgp_set_log_ss(DBSSGP);</span><br><span> log_parse_category_mask(osmo_stderr_target, "DRLCMAC,1:DRLCMACDATA,3:DRLCMACDL,3:DRLCMACUL,3:"</span><br><span> "DRLCMACSCHED,1:DRLCMACMEAS,3:DNS,3:DBSSGP,3:DPCU,5:"</span><br><span style="color: hsl(0, 100%, 40%);">- "DL1IF,6:DTBF,1:DTBFUL,1:DTBFDL,1:");</span><br><span style="color: hsl(120, 100%, 40%);">+ "DL1IF,6:DTBF,1:DTBFUL,1:DTBFDL,1:DLGLOBAL,2:");</span><br><span> </span><br><span> vty_init(&pcu_vty_info);</span><br><span> pcu_vty_init(&gprs_log_info);</span><br><span>diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err</span><br><span>index e788ccc..4e15256 100644</span><br><span>--- a/tests/tbf/TbfTest.err</span><br><span>+++ b/tests/tbf/TbfTest.err</span><br><span>@@ -1337,6 +1337,7 @@</span><br><span> - Failed to find a usable TRX (TFI exhausted)</span><br><span> No PDCH resource</span><br><span> Destroying MS object, TLLI = 0x00000000</span><br><span style="color: hsl(120, 100%, 40%);">+counter group 'bssgp:bss_ctx' already exists for index 1234, instead using index 1235. This is a software bug that needs fixing.</span><br><span> ********** DL-TBF starts here **********</span><br><span> Allocating DL TBF: MS_CLASS=45/0</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span>@@ -3014,8 +3015,10 @@</span><br><span> TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=FINISHED) starting timer T3191 [final block (DL-TBF)] with 0 sec. 0 microsec, cur_fn=0</span><br><span> TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=FINISHED) Scheduled Ack/Nack polling on FN=2654461, TS=7</span><br><span> TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=FINISHED) msg block (BSN 10, CS-1): 0f 03 14 4d 43 20 50 41 43 4b 45 54 20 30 39 20 28 54 42 46 20 32 29 </span><br><span style="color: hsl(120, 100%, 40%);">+counter group 'bssgp:bss_ctx' already exists for index 1234, instead using index 1236. This is a software bug that needs fixing.</span><br><span> Not accepting non-EGPRS phone in EGPRS-only mode</span><br><span> No PDCH resource</span><br><span style="color: hsl(120, 100%, 40%);">+counter group 'bssgp:bss_ctx' already exists for index 1234, instead using index 1237. This is a software bug that needs fixing.</span><br><span> ********** DL-TBF starts here **********</span><br><span> Allocating DL TBF: MS_CLASS=12/0</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span>@@ -5904,6 +5907,7 @@</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) set ass. type PACCH [prev CCCH:0, PACCH:0]</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) starting timer T0 [assignment (PACCH)] with 2 sec. 0 microsec, cur_fn=0</span><br><span> TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN EGPRS) appending 256 bytes</span><br><span style="color: hsl(120, 100%, 40%);">+counter group 'bssgp:bss_ctx' already exists for index 1234, instead using index 1238. This is a software bug that needs fixing.</span><br><span> ********** DL-TBF starts here **********</span><br><span> Allocating DL TBF: MS_CLASS=11/11</span><br><span> Creating MS object, TLLI = 0x00000000</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13165">change 13165</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13165"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6317eccfb1408c5c9d07110a8b059f5ceb5d2afc </div>
<div style="display:none"> Gerrit-Change-Number: 13165 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Willmann <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>