<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13166">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Max: Looks good to me, approved
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log time in tcpdump-start and -stop.sh<br><br>Also log the testcase name in tcpdump-start.sh.<br><br>The output now looks like<br><br>    ------ MSC_Tests.TC_mo_cc_bssmap_clear ------<br>    Thu Mar  7 13:21:00 UTC 2019<br>    [...]<br>    Thu Mar  7 13:21:04 UTC 2019<br>    ====== MSC_Tests.TC_mo_cc_bssmap_clear pass ======<br><br>The reason to log start and end dates came up like this: I noticed a segfault<br>in a tested program at a specific time. From the timestamp I tried to find out<br>which of the tests saw the failure. (After a segfault, all subsequent tests run<br>and fail, but it is not obvious which failure occured because of a segfault,<br>and which ones just normally failed before that.) Looking at the timestamps of<br>the log files didn't help, because the ttcn3_logmerge touched those after the<br>tests completed. So the only way is to cat each individual log file and find<br>the timestamp.<br><br>So this adds an overview of the timestamps without needing to open log files.<br><br>Change-Id: I0832d9b5df599baad5dec8d3a993481b4286fbb3<br>---<br>M ttcn3-tcpdump-start.sh<br>M ttcn3-tcpdump-stop.sh<br>2 files changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh</span><br><span>index 395941d..747002b 100755</span><br><span>--- a/ttcn3-tcpdump-start.sh</span><br><span>+++ b/ttcn3-tcpdump-start.sh</span><br><span>@@ -4,6 +4,9 @@</span><br><span> TCPDUMP=/usr/sbin/tcpdump</span><br><span> TESTCASE=$1</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+echo "------ $TESTCASE ------"</span><br><span style="color: hsl(120, 100%, 40%);">+date</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if [ "z$TTCN3_PCAP_PATH" = "z" ]; then</span><br><span>       TTCN3_PCAP_PATH=/tmp</span><br><span> fi</span><br><span>diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh</span><br><span>index 9404841..baabefe 100755</span><br><span>--- a/ttcn3-tcpdump-stop.sh</span><br><span>+++ b/ttcn3-tcpdump-stop.sh</span><br><span>@@ -4,6 +4,8 @@</span><br><span> TESTCASE=$1</span><br><span> VERDICT="$2"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+date</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if [ x"$VERDICT" = x"pass" ]; then</span><br><span>         echo "\033[1;32m====== $TESTCASE $VERDICT ======\033[0m"</span><br><span> else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13166">change 13166</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13166"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0832d9b5df599baad5dec8d3a993481b4286fbb3 </div>
<div style="display:none"> Gerrit-Change-Number: 13166 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>