<p>Daniel Willmann has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13133">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">encoding: Fixes TMSI vs MI bit selection in repeated page info<br><br>Change-Id: Iddb00b9133f523f4ba09c8f1fc5694e62dc46fbf<br>---<br>M src/encoding.cpp<br>1 file changed, 15 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/33/13133/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index 4c8cdb0..019de52 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -1066,6 +1066,20 @@</span><br><span> return wp;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 44.060 ยง 11.2.10:</span><br><span style="color: hsl(120, 100%, 40%);">+ < Repeated Page info struct > ::=</span><br><span style="color: hsl(120, 100%, 40%);">+ { 0 -- Page request for TBF establishment</span><br><span style="color: hsl(120, 100%, 40%);">+ { 0 < PTMSI : bit (32) ></span><br><span style="color: hsl(120, 100%, 40%);">+ | 1 < Length of Mobile Identity contents : bit (4) ></span><br><span style="color: hsl(120, 100%, 40%);">+ < Mobile Identity : octet (val (Length of Mobile Identity contents)) > }</span><br><span style="color: hsl(120, 100%, 40%);">+ | 1 -- Page request for RR conn. establishment</span><br><span style="color: hsl(120, 100%, 40%);">+ { 0 < TMSI : bit (32) ></span><br><span style="color: hsl(120, 100%, 40%);">+ | 1 < Length of Mobile Identity contents : bit (4) ></span><br><span style="color: hsl(120, 100%, 40%);">+ < Mobile Identity : octet (val (Length of Mobile Identity contents)) > }</span><br><span style="color: hsl(120, 100%, 40%);">+ < CHANNEL_NEEDED : bit (2) ></span><br><span style="color: hsl(120, 100%, 40%);">+ { 0 | 1 < eMLPP_PRIORITY : bit (3) > }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> unsigned Encoding::write_repeated_page_info(bitvec * dest, unsigned& wp, uint8_t len,</span><br><span> uint8_t *identity, uint8_t chan_needed)</span><br><span> {</span><br><span>@@ -1078,7 +1092,7 @@</span><br><span> identity++;</span><br><span> len--;</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- bitvec_write_field(dest, &wp,0x0,1); // MI</span><br><span style="color: hsl(120, 100%, 40%);">+ bitvec_write_field(dest, &wp,0x1,1); // MI</span><br><span> bitvec_write_field(dest, &wp,len,4); // MI len</span><br><span> }</span><br><span> while (len) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13133">change 13133</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13133"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iddb00b9133f523f4ba09c8f1fc5694e62dc46fbf </div>
<div style="display:none"> Gerrit-Change-Number: 13133 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Willmann <dwillmann@sysmocom.de> </div>