<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13129">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">coding: check gsm0503_rach_*() results<br><br>Check return value of RACH encode/decode functions and fail test on<br>unexpected results.<br><br>Change-Id: I41bfa808e3c064a11152e7ce8ee77a01d38a0744<br>Related: OS#1854<br>---<br>M tests/coding/coding_test.c<br>1 file changed, 10 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/coding/coding_test.c b/tests/coding/coding_test.c</span><br><span>index 7b4f2a5..2b0830f 100644</span><br><span>--- a/tests/coding/coding_test.c</span><br><span>+++ b/tests/coding/coding_test.c</span><br><span>@@ -104,13 +104,14 @@</span><br><span> </span><br><span> static void test_rach(uint8_t bsic, uint8_t ra)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+   int rc;</span><br><span>      uint8_t result;</span><br><span>      ubit_t bursts_u[36];</span><br><span>         sbit_t bursts_s[36];</span><br><span> </span><br><span>     /* Encode L2 message */</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Encoding: %02x\n", ra);</span><br><span style="color: hsl(0, 100%, 40%);">-       gsm0503_rach_ext_encode(bursts_u, ra, bsic, false);</span><br><span style="color: hsl(120, 100%, 40%);">+   rc = gsm0503_rach_ext_encode(bursts_u, ra, bsic, false);</span><br><span style="color: hsl(120, 100%, 40%);">+      printf("Encoding: %02x%s\n", ra, (rc != 0) ? " FAIL" : "");</span><br><span> </span><br><span>        /* Prepare soft-bits */</span><br><span>      osmo_ubit2sbit(bursts_s, bursts_u, 36);</span><br><span>@@ -123,8 +124,8 @@</span><br><span>        memset(bursts_s + 6, 0, 8);</span><br><span> </span><br><span>      /* Decode, correcting errors */</span><br><span style="color: hsl(0, 100%, 40%);">- gsm0503_rach_decode_ber(&result, bursts_s, bsic, NULL, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-       printf("Decoded: %02x\n", result);</span><br><span style="color: hsl(120, 100%, 40%);">+  rc = gsm0503_rach_decode_ber(&result, bursts_s, bsic, NULL, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+        printf("Decoded: %02x%s\n", result, (rc != 0) ? " FAIL" : "");</span><br><span> </span><br><span>     if (ra != result)</span><br><span>            printf("FAIL [RACH]: encoded %u != %u decoded\n", ra, result);</span><br><span>@@ -134,13 +135,14 @@</span><br><span> </span><br><span> static void test_rach_ext(uint8_t bsic, uint16_t ra)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     int rc;</span><br><span>      uint16_t result = 3000; /* Max ext. RA is 2^11 = 2048 */</span><br><span>     ubit_t bursts_u[36];</span><br><span>         sbit_t bursts_s[36];</span><br><span> </span><br><span>     /* Encode L2 message */</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Encoding: %02x\n", ra);</span><br><span style="color: hsl(0, 100%, 40%);">-       gsm0503_rach_ext_encode(bursts_u, ra, bsic, true);</span><br><span style="color: hsl(120, 100%, 40%);">+    rc = gsm0503_rach_ext_encode(bursts_u, ra, bsic, true);</span><br><span style="color: hsl(120, 100%, 40%);">+       printf("Encoding: %02x%s\n", ra, (rc != 0) ? " FAIL" : "");</span><br><span> </span><br><span>        /* Prepare soft-bits */</span><br><span>      osmo_ubit2sbit(bursts_s, bursts_u, 36);</span><br><span>@@ -153,8 +155,8 @@</span><br><span>        memset(bursts_s + 9, 0, 8);</span><br><span> </span><br><span>      /* Decode, correcting errors */</span><br><span style="color: hsl(0, 100%, 40%);">- gsm0503_rach_ext_decode_ber(&result, bursts_s, bsic, NULL, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-   printf("Decoded: %02x\n", result);</span><br><span style="color: hsl(120, 100%, 40%);">+  rc = gsm0503_rach_ext_decode_ber(&result, bursts_s, bsic, NULL, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+    printf("Decoded: %02x%s\n", result, (rc != 0) ? " FAIL" : "");</span><br><span> </span><br><span>     if (ra != result)</span><br><span>            printf("FAIL [RACH ext]: encoded %u != %u decoded\n", ra, result);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13129">change 13129</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13129"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I41bfa808e3c064a11152e7ce8ee77a01d38a0744 </div>
<div style="display:none"> Gerrit-Change-Number: 13129 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>