<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13052">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">EDGE tests: remove no-op check<br><br>The headerTypeControl() function always return constant and is only used<br>inside OSMO_ASSERT() which compares it to the very same constant which<br>makes it no-op. Let's remove this clutter.<br><br>Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4<br>---<br>M src/gprs_coding_scheme.h<br>M tests/edge/EdgeTest.cpp<br>2 files changed, 0 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h</span><br><span>index 1acb14b..31f0940 100644</span><br><span>--- a/src/gprs_coding_scheme.h</span><br><span>+++ b/src/gprs_coding_scheme.h</span><br><span>@@ -100,7 +100,6 @@</span><br><span>         uint8_t optionalPaddingBits() const;</span><br><span>         const char *name() const;</span><br><span>    HeaderType headerTypeData() const;</span><br><span style="color: hsl(0, 100%, 40%);">-      HeaderType headerTypeControl() const;</span><br><span> </span><br><span>    static GprsCodingScheme getBySizeUL(unsigned size);</span><br><span>  static GprsCodingScheme getGprsByNum(unsigned num);</span><br><span>@@ -146,11 +145,6 @@</span><br><span>   return (isGprs() && o.isGprs()) || (isEgprs() && o.isEgprs());</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-inline GprsCodingScheme::HeaderType GprsCodingScheme::headerTypeControl() const</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- return HEADER_GPRS_CONTROL;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> inline GprsCodingScheme::GprsCodingScheme(Scheme s)</span><br><span>  : m_scheme(s)</span><br><span> {</span><br><span>diff --git a/tests/edge/EdgeTest.cpp b/tests/edge/EdgeTest.cpp</span><br><span>index 6ce2334..0cb123e 100644</span><br><span>--- a/tests/edge/EdgeTest.cpp</span><br><span>+++ b/tests/edge/EdgeTest.cpp</span><br><span>@@ -170,8 +170,6 @@</span><br><span>            /* Check header types */</span><br><span>             OSMO_ASSERT(current_cs.headerTypeData() ==</span><br><span>                   GprsCodingScheme::HEADER_GPRS_DATA);</span><br><span style="color: hsl(0, 100%, 40%);">-            OSMO_ASSERT(current_cs.headerTypeControl() ==</span><br><span style="color: hsl(0, 100%, 40%);">-                   GprsCodingScheme::HEADER_GPRS_CONTROL);</span><br><span> </span><br><span>          check_coding_scheme(current_cs, GprsCodingScheme::GPRS);</span><br><span>     }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13052">change 13052</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13052"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie0f81fe05a2b3f432de7d1f3446e8115d7524ff4 </div>
<div style="display:none"> Gerrit-Change-Number: 13052 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Willmann <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>