<p>osmith <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13111">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSUP_Types.ttcn: add CHECK-IMEI message<br><br>Implement necessary messages for Procedure Check_IMEI_VLR (TS 23.018<br>Chapter 7.1.2.9). This lets the VLR ask the EIR to check if an IMEI<br>is valid. In the Osmocom stack, we don't have an EIR and this request<br>is handled by the HLR. We are able to store the IMEI in the HLR as<br>side-effect (OS#2541).<br><br>This is roughly based on TS 29.002 8.7.1 MAP_CHECK_IMEI service, but<br>only implements the bare minimum required IEs (imei and imei_result).<br><br>Related: OS#3733<br>Change-Id: Ie1ae5c66ad3f9b42b345020de62a0c276cd8d709<br>---<br>M library/GSUP_Types.ttcn<br>1 file changed, 55 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn</span><br><span>index 6cc6dde..c024d37 100644</span><br><span>--- a/library/GSUP_Types.ttcn</span><br><span>+++ b/library/GSUP_Types.ttcn</span><br><span>@@ -52,7 +52,10 @@</span><br><span> OSMO_GSUP_SM_RP_UI_IE ('43'O),</span><br><span> OSMO_GSUP_SM_RP_CAUSE_IE ('44'O),</span><br><span> OSMO_GSUP_SM_RP_MMS_IE ('45'O),</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_GSUP_SM_ALERT_RSN_IE ('46'O)</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_SM_ALERT_RSN_IE ('46'O),</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_IMEI_IE ('50'O),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_IMEI_RESULT_IE ('51'O)</span><br><span> } with { variant "FIELDLENGTH(8)" };</span><br><span> </span><br><span> type enumerated GSUP_MessageType {</span><br><span>@@ -96,7 +99,11 @@</span><br><span> </span><br><span> OSMO_GSUP_MSGT_READY_FOR_SM_REQUEST ('00101100'B),</span><br><span> OSMO_GSUP_MSGT_READY_FOR_SM_ERROR ('00101101'B),</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_GSUP_MSGT_READY_FOR_SM_RESULT ('00101110'B)</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_MSGT_READY_FOR_SM_RESULT ('00101110'B),</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST ('00110000'B),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_MSGT_CHECK_IMEI_ERROR ('00110001'B),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_MSGT_CHECK_IMEI_RESULT ('00110010'B)</span><br><span> } with { variant "FIELDLENGTH(8)" };</span><br><span> </span><br><span> type enumerated GSUP_CancelType {</span><br><span>@@ -109,6 +116,11 @@</span><br><span> OSMO_GSUP_CN_DOMAIN_CS (2)</span><br><span> } with { variant "FIELDLENGTH(8)" };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+type enumerated GSUP_IMEIResult {</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_IMEI_RESULT_ACK (0),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_GSUP_IMEI_RESULT_NACK (1)</span><br><span style="color: hsl(120, 100%, 40%);">+} with { variant "FIELDLENGTH(8)" };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> type enumerated GSUP_SessionState {</span><br><span> OSMO_GSUP_SESSION_STATE_NONE (0),</span><br><span> OSMO_GSUP_SESSION_STATE_BEGIN (1),</span><br><span>@@ -121,6 +133,11 @@</span><br><span> hexstring digits optional</span><br><span> } with { variant (len) "LENGTHTO(digits)" };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+type record GSUP_IMEI {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t len,</span><br><span style="color: hsl(120, 100%, 40%);">+ hexstring digits optional</span><br><span style="color: hsl(120, 100%, 40%);">+} with { variant (len) "LENGTHTO(digits)" };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> type record GSUP_IE {</span><br><span> GSUP_IEI tag,</span><br><span> uint8_t len,</span><br><span>@@ -156,6 +173,8 @@</span><br><span> sm_rp_cause, tag = OSMO_GSUP_SM_RP_CAUSE_IE;</span><br><span> sm_rp_mms, tag = OSMO_GSUP_SM_RP_MMS_IE;</span><br><span> sm_alert_rsn, tag = OSMO_GSUP_SM_ALERT_RSN_IE;</span><br><span style="color: hsl(120, 100%, 40%);">+ imei, tag = OSMO_GSUP_IMEI_IE;</span><br><span style="color: hsl(120, 100%, 40%);">+ imei_result, tag = OSMO_GSUP_IMEI_RESULT_IE;</span><br><span> )"</span><br><span> };</span><br><span> </span><br><span>@@ -197,7 +216,10 @@</span><br><span> octetstring sm_rp_ui,</span><br><span> OCT1 sm_rp_cause,</span><br><span> OCT1 sm_rp_mms,</span><br><span style="color: hsl(0, 100%, 40%);">- GSUP_SM_ALERT_RSN_Type sm_alert_rsn</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP_SM_ALERT_RSN_Type sm_alert_rsn,</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP_IMEI imei,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP_IMEIResult imei_result</span><br><span> };</span><br><span> </span><br><span> type record GSUP_PDU {</span><br><span>@@ -674,6 +696,36 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+template (value) GSUP_IE ts_GSUP_IE_IMEI_IE(GSUP_IMEI imei) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_IMEI_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+ len := 0, /* overwritten */</span><br><span style="color: hsl(120, 100%, 40%);">+ val := {</span><br><span style="color: hsl(120, 100%, 40%);">+ imei := imei</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+template GSUP_IE tr_GSUP_IE_IMEI_IE(template GSUP_IMEI imei) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_IMEI_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+ len := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ val := {</span><br><span style="color: hsl(120, 100%, 40%);">+ imei := imei</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) GSUP_IE ts_GSUP_IE_IMEI_RESULT_IE(GSUP_IMEIResult result) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_IMEI_RESULT_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+ len := 0, /* overwritten */</span><br><span style="color: hsl(120, 100%, 40%);">+ val := {</span><br><span style="color: hsl(120, 100%, 40%);">+ imei_result := result</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+template GSUP_IE tr_GSUP_IE_IMEI_RESULT_IE(template GSUP_IMEIResult result) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ tag := OSMO_GSUP_IMEI_RESULT_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+ len := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ val := {</span><br><span style="color: hsl(120, 100%, 40%);">+ imei_result := result</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Possible identity types for SM-RP-{OA|DA} IEs */</span><br><span> type enumerated GSUP_SM_RP_ODA_IdType {</span><br><span> OSMO_GSUP_SM_RP_ODA_ID_NONE ('00'O),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13111">change 13111</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13111"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie1ae5c66ad3f9b42b345020de62a0c276cd8d709 </div>
<div style="display:none"> Gerrit-Change-Number: 13111 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Willmann <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>