<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13081">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808_utils: fix gsm48 multirate configuration generator<br><br>The function gsm0808_sc_cfg_from_gsm48_mr_cfg() takes an S15 to S0<br>bitmask and converts that bitmask into an AMR multirate configuration<br>struct.<br><br>Unfortunately the current implementation implements 3GPP TS 28.062,<br>Table 7.11.3.1.3-2 wrongly in some aspects. Lets fix this.<br><br>- Fix wrong interpretation of the bitpatterns<br>- 5,15K is invalid and must never be selected<br>- Make sure that no more than 4 rates are selected in the active set<br>- Extend unit-test<br><br>Change-Id: I6fd7f4073b84093742c322752f2fd878d1071e15<br>Related: SYS#4470<br>---<br>M include/osmocom/gsm/gsm0808_utils.h<br>M include/osmocom/gsm/protocol/gsm_08_08.h<br>M src/gsm/gsm0808_utils.c<br>M tests/gsm0808/gsm0808_test.c<br>M tests/gsm0808/gsm0808_test.ok<br>5 files changed, 306 insertions(+), 62 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/13081/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsm0808_utils.h b/include/osmocom/gsm/gsm0808_utils.h</span><br><span>index 2b48be7..4967987 100644</span><br><span>--- a/include/osmocom/gsm/gsm0808_utils.h</span><br><span>+++ b/include/osmocom/gsm/gsm0808_utils.h</span><br><span>@@ -127,7 +127,7 @@</span><br><span> int gsm0808_speech_codec_from_chan_type(struct gsm0808_speech_codec *sc,</span><br><span> uint8_t perm_spch);</span><br><span> uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(const struct gsm48_multi_rate_conf *cfg, bool fr);</span><br><span style="color: hsl(0, 100%, 40%);">-void gsm48_mr_cfg_from_gsm0808_sc_cfg(struct gsm48_multi_rate_conf *cfg, uint16_t s15_s0);</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_mr_cfg_from_gsm0808_sc_cfg(struct gsm48_multi_rate_conf *cfg, uint16_t s15_s0);</span><br><span> </span><br><span> /*! \returns 3GPP TS 08.08 ยง3.2.2.5 Class of a given Cause */</span><br><span> static inline enum gsm0808_cause_class gsm0808_cause_class(enum gsm0808_cause cause)</span><br><span>diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>index 67dc6ee..aa01ee5 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>@@ -553,6 +553,20 @@</span><br><span> GSM0808_SC_CFG_DEFAULT_AMR_12_2 = 0xc082</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*! Single speech codec configurations broken down by reate.</span><br><span style="color: hsl(120, 100%, 40%);">+ * See also: 3GPP TS 28.062, Table 7.11.3.1.3-2: Preferred Configurations for</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Adaptive Multi-Rate Codec Types. */</span><br><span style="color: hsl(120, 100%, 40%);">+enum gsm0808_speech_codec_rate {</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_4_75 = 0x0001,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 = 0x0002,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_5_90 = 0x0004,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_6_70 = 0x0008,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_7_40 = 0x0010,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_7_95 = 0x0020,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_10_2 = 0x0040,</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_12_2 = 0x0080,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 3GPP TS 48.008 3.2.2.103 Speech Codec List */</span><br><span> #define SPEECH_CODEC_MAXLEN 255</span><br><span> struct gsm0808_speech_codec_list {</span><br><span>diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c</span><br><span>index 606899e..6b7a8ef 100644</span><br><span>--- a/src/gsm/gsm0808_utils.c</span><br><span>+++ b/src/gsm/gsm0808_utils.c</span><br><span>@@ -1346,42 +1346,82 @@</span><br><span> /*! Determine a GSM 04.08 AMR configuration struct from a set of speech codec</span><br><span> * configuration bits (S0-S15)</span><br><span> * \param[out] cfg AMR configuration in GSM 04.08 format.</span><br><span style="color: hsl(0, 100%, 40%);">- * \param[in] s15_s0 configuration bits (S0-S15). */</span><br><span style="color: hsl(0, 100%, 40%);">-void gsm48_mr_cfg_from_gsm0808_sc_cfg(struct gsm48_multi_rate_conf *cfg,</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t s15_s0)</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] s15_s0 configuration bits (S15-S0).</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns zero when successful; negative on error */</span><br><span style="color: hsl(120, 100%, 40%);">+int gsm48_mr_cfg_from_gsm0808_sc_cfg(struct gsm48_multi_rate_conf *cfg,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t s15_s0)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int count = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Note: See also: 3GPP TS 28.062</span><br><span style="color: hsl(120, 100%, 40%);">+ * Table 7.11.3.1.3-2: Preferred Configurations for the Adaptive</span><br><span style="color: hsl(120, 100%, 40%);">+ * Multi-Rate Codec Types */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> memset(cfg, 0, sizeof(*cfg));</span><br><span> </span><br><span> /* Strip option bits */</span><br><span> s15_s0 &= 0x00ff;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Rate 5,15k must always be present */</span><br><span style="color: hsl(0, 100%, 40%);">- cfg->m5_15 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Rate 5,15k can never be selected (see table) */</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m5_15 = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if ((s15_s0 & GSM0808_SC_CFG_DEFAULT_AMR_4_75 & 0xff) ==</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_4_75 & 0xff))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 & 0xff) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Table Table 7.11.3.1.3-2 lists one mode that selects 4</span><br><span style="color: hsl(120, 100%, 40%);">+ * rates at once (Config-NB-Code = 1). The rates selected</span><br><span style="color: hsl(120, 100%, 40%);">+ * are known to be compatible between GERAN and UTRAN, since</span><br><span style="color: hsl(120, 100%, 40%);">+ * an active set must not contain more than four rates at</span><br><span style="color: hsl(120, 100%, 40%);">+ * a time, we ignore all other settings as they are either</span><br><span style="color: hsl(120, 100%, 40%);">+ * redundaned or excess settings (invalid) */</span><br><span> cfg->m4_75 = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- if ((s15_s0 & GSM0808_SC_CFG_DEFAULT_AMR_5_90 & 0xff) ==</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_5_90 & 0xff))</span><br><span> cfg->m5_90 = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- if ((s15_s0 & GSM0808_SC_CFG_DEFAULT_AMR_6_70 & 0xff) ==</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_6_70 & 0xff))</span><br><span style="color: hsl(0, 100%, 40%);">- cfg->m6_70 = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- if ((s15_s0 & GSM0808_SC_CFG_DEFAULT_AMR_7_40 & 0xff) ==</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_7_40 & 0xff))</span><br><span> cfg->m7_40 = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- if ((s15_s0 & GSM0808_SC_CFG_DEFAULT_AMR_7_95 & 0xff) ==</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_7_95 & 0xff))</span><br><span style="color: hsl(0, 100%, 40%);">- cfg->m7_95 = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- if ((s15_s0 & GSM0808_SC_CFG_DEFAULT_AMR_10_2 & 0xff) ==</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_10_2 & 0xff))</span><br><span style="color: hsl(0, 100%, 40%);">- cfg->m10_2 = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- if ((s15_s0 & GSM0808_SC_CFG_DEFAULT_AMR_12_2 & 0xff) ==</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_12_2 & 0xff))</span><br><span> cfg->m12_2 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count += 4;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check the bits in s15_s0 and set the flags for the</span><br><span style="color: hsl(120, 100%, 40%);">+ * respective rates. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_4_75 && !cfg->m4_75) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m4_75 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_5_90 && !cfg->m5_90) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m5_90 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_6_70) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m6_70 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_7_40 && !cfg->m7_40) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m7_40 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_7_95) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m7_95 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_10_2) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m10_2 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (s15_s0 & GSM0808_SC_CFG_AMR_12_2 && !cfg->m12_2) {</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->m12_2 = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ count++;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The resulting multirate-configuration must not contain an active</span><br><span style="color: hsl(120, 100%, 40%);">+ * set of more than four codec rates. The active set also must contain</span><br><span style="color: hsl(120, 100%, 40%);">+ * at least one rate. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (count > 4)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (count == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EINVAL;</span><br><span> </span><br><span> cfg->ver = 1;</span><br><span> cfg->icmi = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span> }</span><br><span> </span><br><span> int gsm0808_get_cipher_reject_cause(const struct tlv_parsed *tp)</span><br><span>diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c</span><br><span>index af90d00..def7771 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.c</span><br><span>+++ b/tests/gsm0808/gsm0808_test.c</span><br><span>@@ -1907,12 +1907,13 @@</span><br><span> static void test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(uint16_t s15_s0)</span><br><span> {</span><br><span> struct gsm48_multi_rate_conf cfg;</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span> </span><br><span> printf("Input:\n");</span><br><span> printf(" S15-S0 = %04x = 0b" OSMO_BIN_SPEC OSMO_BIN_SPEC "\n", s15_s0,</span><br><span> OSMO_BIN_PRINT(s15_s0 >> 8), OSMO_BIN_PRINT(s15_s0));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- gsm48_mr_cfg_from_gsm0808_sc_cfg(&cfg, s15_s0);</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = gsm48_mr_cfg_from_gsm0808_sc_cfg(&cfg, s15_s0);</span><br><span> </span><br><span> printf("Output:\n");</span><br><span> printf(" m4_75= %u smod= %u\n", cfg.m4_75, cfg.smod);</span><br><span>@@ -1924,6 +1925,9 @@</span><br><span> printf(" m10_2= %u\n", cfg.m10_2);</span><br><span> printf(" m12_2= %u\n", cfg.m12_2);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc != 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ printf(" Result invalid!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> printf("\n");</span><br><span> }</span><br><span> </span><br><span>@@ -1931,7 +1935,8 @@</span><br><span> {</span><br><span> printf("Testing gsm48_mr_cfg_from_gsm0808_sc_cfg():\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Only one codec per setting */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Test with settings as defined in 3GPP TS 28.062, Table 7.11.3.1.3-2,</span><br><span style="color: hsl(120, 100%, 40%);">+ * (up to four codecs may become selected) */</span><br><span> test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single</span><br><span> (GSM0808_SC_CFG_DEFAULT_AMR_4_75);</span><br><span> test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single</span><br><span>@@ -1949,15 +1954,40 @@</span><br><span> test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single</span><br><span> (GSM0808_SC_CFG_DEFAULT_AMR_12_2);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Combinations */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Test with settings as defined in 3GPP TS 28.062, Table 7.11.3.1.3-2,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but pick only one distinctive setting at a time */</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_4_75);</span><br><span> test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_4_75 | GSM0808_SC_CFG_DEFAULT_AMR_6_70 |</span><br><span style="color: hsl(0, 100%, 40%);">- GSM0808_SC_CFG_DEFAULT_AMR_10_2);</span><br><span style="color: hsl(120, 100%, 40%);">+ (GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_5_90);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_6_70);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_7_40);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_7_95);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_10_2);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_12_2);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Arbitrary, but valid combinations */</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_7_40 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_6_70 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_10_2);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_7_95 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_4_75);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_5_90 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_12_2);</span><br><span> test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_10_2 | GSM0808_SC_CFG_DEFAULT_AMR_12_2 |</span><br><span style="color: hsl(0, 100%, 40%);">- GSM0808_SC_CFG_DEFAULT_AMR_7_40);</span><br><span style="color: hsl(120, 100%, 40%);">+ (GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 | GSM0808_SC_CFG_AMR_5_90 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_12_2);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Invalid combinations */</span><br><span> test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single</span><br><span style="color: hsl(0, 100%, 40%);">- (GSM0808_SC_CFG_DEFAULT_AMR_7_95 | GSM0808_SC_CFG_DEFAULT_AMR_12_2);</span><br><span style="color: hsl(120, 100%, 40%);">+ (GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 | GSM0808_SC_CFG_AMR_6_70);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(GSM0808_SC_CFG_AMR_7_40 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_6_70 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_10_2 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_7_95 |</span><br><span style="color: hsl(120, 100%, 40%);">+ GSM0808_SC_CFG_AMR_4_75);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(0x0000);</span><br><span style="color: hsl(120, 100%, 40%);">+ test_gsm48_mr_cfg_from_gsm0808_sc_cfg_single(0xffff);</span><br><span> }</span><br><span> </span><br><span> struct test_cell_id_matching_data {</span><br><span>@@ -2292,7 +2322,6 @@</span><br><span> test_gsm0808_enc_dec_cell_id_ci();</span><br><span> test_gsm0808_enc_dec_cell_id_lac_and_ci();</span><br><span> test_gsm0808_enc_dec_cell_id_global();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> test_gsm0808_sc_cfg_from_gsm48_mr_cfg();</span><br><span> test_gsm48_mr_cfg_from_gsm0808_sc_cfg();</span><br><span> </span><br><span>diff --git a/tests/gsm0808/gsm0808_test.ok b/tests/gsm0808/gsm0808_test.ok</span><br><span>index e7df007..b26a0a1 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.ok</span><br><span>+++ b/tests/gsm0808/gsm0808_test.ok</span><br><span>@@ -315,43 +315,44 @@</span><br><span> S15-S0 = ff03 = 0b1111111100000011</span><br><span> Output:</span><br><span> m4_75= 1 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 1</span><br><span> m7_95= 0</span><br><span> m10_2= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 1</span><br><span> </span><br><span> Input:</span><br><span> S15-S0 = 0000 = 0b0000000000000000</span><br><span> Output:</span><br><span> m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 0</span><br><span> m6_70= 0 nscb= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 0</span><br><span> m7_95= 0</span><br><span> m10_2= 0</span><br><span> m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ Result invalid!</span><br><span> </span><br><span> Input:</span><br><span> S15-S0 = ff06 = 0b1111111100000110</span><br><span> Output:</span><br><span style="color: hsl(0, 100%, 40%);">- m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span> m5_90= 1 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 1</span><br><span> m7_95= 0</span><br><span> m10_2= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 1</span><br><span> </span><br><span> Input:</span><br><span> S15-S0 = 3e08 = 0b0011111000001000</span><br><span> Output:</span><br><span> m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span> m5_90= 0 icmi= 1</span><br><span> m6_70= 1 nscb= 0</span><br><span> m7_40= 0 ver= 1</span><br><span>@@ -362,20 +363,20 @@</span><br><span> Input:</span><br><span> S15-S0 = 0c12 = 0b0000110000010010</span><br><span> Output:</span><br><span style="color: hsl(0, 100%, 40%);">- m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span> m7_40= 1 ver= 1</span><br><span> m7_95= 0</span><br><span> m10_2= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 1</span><br><span> </span><br><span> Input:</span><br><span> S15-S0 = c020 = 0b1100000000100000</span><br><span> Output:</span><br><span> m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span> m5_90= 0 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span> m7_40= 0 ver= 1</span><br><span>@@ -387,7 +388,7 @@</span><br><span> S15-S0 = 3040 = 0b0011000001000000</span><br><span> Output:</span><br><span> m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span> m5_90= 0 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span> m7_40= 0 ver= 1</span><br><span>@@ -398,51 +399,211 @@</span><br><span> Input:</span><br><span> S15-S0 = c082 = 0b1100000010000010</span><br><span> Output:</span><br><span style="color: hsl(0, 100%, 40%);">- m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 1</span><br><span> m7_95= 0</span><br><span> m10_2= 0</span><br><span> m12_2= 1</span><br><span> </span><br><span> Input:</span><br><span style="color: hsl(0, 100%, 40%);">- S15-S0 = ff4b = 0b1111111101001011</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0001 = 0b0000000000000001</span><br><span> Output:</span><br><span> m4_75= 1 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0002 = 0b0000000000000010</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0004 = 0b0000000000000100</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 0 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0008 = 0b0000000000001000</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 0 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span> m5_90= 0 icmi= 1</span><br><span> m6_70= 1 nscb= 0</span><br><span> m7_40= 0 ver= 1</span><br><span> m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0010 = 0b0000000000010000</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 0 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0020 = 0b0000000000100000</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 0 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0040 = 0b0000000001000000</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 0 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span> m10_2= 1</span><br><span> m12_2= 0</span><br><span> </span><br><span> Input:</span><br><span style="color: hsl(0, 100%, 40%);">- S15-S0 = fcd2 = 0b1111110011010010</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0080 = 0b0000000010000000</span><br><span> Output:</span><br><span> m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span> m5_90= 0 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m7_40= 1 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 1</span><br><span> m7_95= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m10_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span> m12_2= 1</span><br><span> </span><br><span> Input:</span><br><span style="color: hsl(0, 100%, 40%);">- S15-S0 = c0a2 = 0b1100000010100010</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0058 = 0b0000000001011000</span><br><span> Output:</span><br><span> m4_75= 0 smod= 0</span><br><span style="color: hsl(0, 100%, 40%);">- m5_15= 1 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 1 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0021 = 0b0000000000100001</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span> m5_90= 0 icmi= 1</span><br><span> m6_70= 0 nscb= 0</span><br><span> m7_40= 0 ver= 1</span><br><span> m7_95= 1</span><br><span> m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0084 = 0b0000000010000100</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 0 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span> m12_2= 1</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0086 = 0b0000000010000110</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 000a = 0b0000000000001010</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 1 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ Result invalid!</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0079 = 0b0000000001111001</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 1 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ Result invalid!</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = 0000 = 0b0000000000000000</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 0 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 0 icmi= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 0 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 0 ver= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ Result invalid!</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Input:</span><br><span style="color: hsl(120, 100%, 40%);">+ S15-S0 = ffff = 0b1111111111111111</span><br><span style="color: hsl(120, 100%, 40%);">+Output:</span><br><span style="color: hsl(120, 100%, 40%);">+ m4_75= 1 smod= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_15= 0 spare= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m5_90= 1 icmi= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m6_70= 1 nscb= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_40= 1 ver= 0</span><br><span style="color: hsl(120, 100%, 40%);">+ m7_95= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m10_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ m12_2= 1</span><br><span style="color: hsl(120, 100%, 40%);">+ Result invalid!</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> test_cell_id_matching</span><br><span> [0] LAC:23 LAC:23 MATCH</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13081">change 13081</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13081"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6fd7f4073b84093742c322752f2fd878d1071e15 </div>
<div style="display:none"> Gerrit-Change-Number: 13081 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>