<p style="white-space: pre-wrap; word-wrap: break-word;">I would also argue the fix and the "cosmetic" change should be separate patches. Thanks!</p><p><a href="https://gerrit.osmocom.org/13078">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13078/1/include/osmocom/netif/amr.h">File include/osmocom/netif/amr.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13078/1/include/osmocom/netif/amr.h@86">Patch Set #1, Line 86:</a> <code style="font-family:monospace,monospace">/* AMR voice frame length (in bytes, rounded),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">might be good to qualify what kind of length.  Length of the AMR codec data after TOC? Length of the RTP payload after RTP header? ...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13078">change 13078</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13078"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-netif </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I65b5da920d58015b875d6dcf17aacdc04b58955e </div>
<div style="display:none"> Gerrit-Change-Number: 13078 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 28 Feb 2019 10:41:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>