<p>Keith Whyte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12599">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Don't deliver alert notifications to ESME not yet bound. <br><br>We create a new ESME in smsc->esme_list on establishment<br>of a TCP connection, yet we do not know the system id <br>or anything else, until the ESME identifies and authenticates.<br><br>So do not send alert notifications until<br>we know the bind status (and system_id)<br><br>Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df<br>---<br>M src/libmsc/smpp_openbsc.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c</span><br><span>index fb9b0f8..9156445 100644</span><br><span>--- a/src/libmsc/smpp_openbsc.c</span><br><span>+++ b/src/libmsc/smpp_openbsc.c</span><br><span>@@ -284,6 +284,11 @@</span><br><span>                /* we currently send an alert notification to each ESME that is</span><br><span>               * connected, and do not require a (non-existant) delivery</span><br><span>            * pending flag to be set before. */</span><br><span style="color: hsl(120, 100%, 40%);">+          if (!esme->bind_flags) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   LOGP(DSMPP, LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+                               "ESME is not (yet) bound, skipping alert\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                       continue;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>            if (!esme->acl->alert_notifications) {</span><br><span>                         LOGP(DSMPP, LOGL_DEBUG,</span><br><span>                              "[%s] is not set to receive Alert Notifications\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12599">change 12599</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12599"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df </div>
<div style="display:none"> Gerrit-Change-Number: 12599 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Keith Whyte <keith@rhizomatica.org> </div>