<p>Holger Freyther has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13072">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pyflakes: Remove occurrences of using undefined variables<br><br>Mention the attribute right away and remove a method that looks<br>to have been broken (more vs. more_rules).<br><br>Change-Id: Iba18a96ff804780e66c69b459e112f9d42b7b2ff<br>---<br>M src/osmo_gsm_tester/bts_nanobts.py<br>M src/osmo_gsm_tester/resource.py<br>2 files changed, 1 insertion(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/72/13072/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/bts_nanobts.py b/src/osmo_gsm_tester/bts_nanobts.py</span><br><span>index 5fe8bae..4cdb98e 100644</span><br><span>--- a/src/osmo_gsm_tester/bts_nanobts.py</span><br><span>+++ b/src/osmo_gsm_tester/bts_nanobts.py</span><br><span>@@ -92,7 +92,7 @@</span><br><span> </span><br><span>     def start(self, keepalive=False):</span><br><span>         if self.conf.get('ipa_unit_id') is None:</span><br><span style="color: hsl(0, 100%, 40%);">-            raise log.Error('No attribute %s provided in conf!' % attr)</span><br><span style="color: hsl(120, 100%, 40%);">+            raise log.Error('No attribute ipa_unit_id provided in conf!')</span><br><span>         self.run_dir = util.Dir(self.suite_run.get_test_run_dir().new_dir(self.name()))</span><br><span>         self._configure()</span><br><span> </span><br><span>diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py</span><br><span>index 29f641e..98651ce 100644</span><br><span>--- a/src/osmo_gsm_tester/resource.py</span><br><span>+++ b/src/osmo_gsm_tester/resource.py</span><br><span>@@ -395,11 +395,6 @@</span><br><span>             raise RuntimeError('adding a list of resources to itself?')</span><br><span>         config.add(self, copy.deepcopy(more))</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    def combine(self, more_rules):</span><br><span style="color: hsl(0, 100%, 40%);">-        if more_rules is self:</span><br><span style="color: hsl(0, 100%, 40%);">-            raise RuntimeError('combining a list of resource rules with itself?')</span><br><span style="color: hsl(0, 100%, 40%);">-        config.combine(self, copy.deepcopy(more))</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     def mark_reserved_by(self, origin_id):</span><br><span>         for key, item_list in self.items():</span><br><span>             for item in item_list:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13072">change 13072</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13072"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iba18a96ff804780e66c69b459e112f9d42b7b2ff </div>
<div style="display:none"> Gerrit-Change-Number: 13072 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>