<p>Holger Freyther has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13071">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pyflakes: Remove assigned but unread variables<br><br>Change-Id: Ie257ac051739ea6f846d1aac2c8f778638b5f8a6<br>---<br>M src/osmo_gsm_tester/modem.py<br>M src/osmo_gsm_tester/osmo_nitb.py<br>M src/osmo_gsm_tester/template.py<br>M src/osmo_gsm_tester/util.py<br>4 files changed, 8 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/71/13071/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/modem.py b/src/osmo_gsm_tester/modem.py</span><br><span>index f9b827a..95ebb6b 100644</span><br><span>--- a/src/osmo_gsm_tester/modem.py</span><br><span>+++ b/src/osmo_gsm_tester/modem.py</span><br><span>@@ -125,7 +125,7 @@</span><br><span>     user_data = (result_handler, error_handler, user_data)</span><br><span> </span><br><span>     # See https://lazka.github.io/pgi-docs/Gio-2.0/classes/DBusProxy.html#Gio.DBusProxy.call</span><br><span style="color: hsl(0, 100%, 40%);">-    ret = instance._bus.con.call(</span><br><span style="color: hsl(120, 100%, 40%);">+    instance._bus.con.call(</span><br><span>         instance._bus_name, instance._path,</span><br><span>         proxymethod._iface_name, proxymethod.__name__,</span><br><span>         GLib.Variant(proxymethod._sinargs, proxymethod_args),</span><br><span>@@ -596,14 +596,14 @@</span><br><span>         if self.is_attached():</span><br><span>             self.detach()</span><br><span>         connmgr = self.dbus.interface(I_CONNMGR)</span><br><span style="color: hsl(0, 100%, 40%);">-        prop = connmgr.SetProperty('RoamingAllowed', Variant('b', allow_roaming))</span><br><span style="color: hsl(0, 100%, 40%);">-        prop = connmgr.SetProperty('Powered', Variant('b', True))</span><br><span style="color: hsl(120, 100%, 40%);">+        connmgr.SetProperty('RoamingAllowed', Variant('b', allow_roaming))</span><br><span style="color: hsl(120, 100%, 40%);">+        connmgr.SetProperty('Powered', Variant('b', True))</span><br><span> </span><br><span>     def detach(self):</span><br><span>         self.dbg('detach')</span><br><span>         connmgr = self.dbus.interface(I_CONNMGR)</span><br><span style="color: hsl(0, 100%, 40%);">-        prop = connmgr.SetProperty('RoamingAllowed', Variant('b', False))</span><br><span style="color: hsl(0, 100%, 40%);">-        prop = connmgr.SetProperty('Powered', Variant('b', False))</span><br><span style="color: hsl(120, 100%, 40%);">+        connmgr.SetProperty('RoamingAllowed', Variant('b', False))</span><br><span style="color: hsl(120, 100%, 40%);">+        connmgr.SetProperty('Powered', Variant('b', False))</span><br><span>         connmgr.DeactivateAll()</span><br><span>         connmgr.ResetContexts() # Requires Powered=false</span><br><span> </span><br><span>@@ -734,7 +734,7 @@</span><br><span>             call_dbus_obj = systembus_get(call_id)</span><br><span>             props = call_dbus_obj.GetProperties()</span><br><span>             state = props.get('State')</span><br><span style="color: hsl(0, 100%, 40%);">-        except Exception as e:</span><br><span style="color: hsl(120, 100%, 40%);">+        except Exception:</span><br><span>             self.log('asking call state for non existent call')</span><br><span>             log.log_exn()</span><br><span>             state = 'disconnected'</span><br><span>diff --git a/src/osmo_gsm_tester/osmo_nitb.py b/src/osmo_gsm_tester/osmo_nitb.py</span><br><span>index 66ab2a6..e161ccb 100644</span><br><span>--- a/src/osmo_gsm_tester/osmo_nitb.py</span><br><span>+++ b/src/osmo_gsm_tester/osmo_nitb.py</span><br><span>@@ -176,8 +176,6 @@</span><br><span>         return osmo_ctrl.OsmoCtrl(self.nitb.addr(), OsmoNitbCtrl.PORT)</span><br><span> </span><br><span>     def subscriber_add(self, imsi, msisdn, ki=None, algo=None):</span><br><span style="color: hsl(0, 100%, 40%);">-        created = False</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         if algo:</span><br><span>             value = '%s,%s,%s,%s' % (imsi,msisdn,algo,ki)</span><br><span>         else:</span><br><span>diff --git a/src/osmo_gsm_tester/template.py b/src/osmo_gsm_tester/template.py</span><br><span>index c890963..6ce7ebd 100644</span><br><span>--- a/src/osmo_gsm_tester/template.py</span><br><span>+++ b/src/osmo_gsm_tester/template.py</span><br><span>@@ -51,7 +51,6 @@</span><br><span>     template = _lookup.get_template(tmpl_name)</span><br><span>     _logger.dbg('rendering', tmpl_name)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    line_info_name = tmpl_name.replace('-', '_').replace('.', '_')</span><br><span>     return template.render(**dict2obj(values))</span><br><span> </span><br><span> # vim: expandtab tabstop=4 shiftwidth=4</span><br><span>diff --git a/src/osmo_gsm_tester/util.py b/src/osmo_gsm_tester/util.py</span><br><span>index 930c86a..e9a1f30 100644</span><br><span>--- a/src/osmo_gsm_tester/util.py</span><br><span>+++ b/src/osmo_gsm_tester/util.py</span><br><span>@@ -64,7 +64,7 @@</span><br><span>             for line in proc.stdout.readlines():</span><br><span>                 if 'inet' in line and ' ' + ip + '/' in line:</span><br><span>                     return line.split()[-1]</span><br><span style="color: hsl(0, 100%, 40%);">-    except Exception as e:</span><br><span style="color: hsl(120, 100%, 40%);">+    except Exception:</span><br><span>         pass</span><br><span>     return None</span><br><span> </span><br><span>@@ -79,7 +79,7 @@</span><br><span>             if words[i] == 'src':</span><br><span>                 return words[i+1]</span><br><span>             i += 1</span><br><span style="color: hsl(0, 100%, 40%);">-    except Exception as e:</span><br><span style="color: hsl(120, 100%, 40%);">+    except Exception:</span><br><span>         pass</span><br><span>     return None</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13071">change 13071</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13071"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie257ac051739ea6f846d1aac2c8f778638b5f8a6 </div>
<div style="display:none"> Gerrit-Change-Number: 13071 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>