<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13004">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Daniel Willmann: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">enlarge gsm0808 msgb headroom<br><br>It should be large enough to prepend a struct osmo_scu_prim to pass down an<br>SCCP stack (see libosmo-sccp). 264 should suffice, but pick the next larger<br>power-of-two instead.<br><br>In osmo-msc, I would like to prepend an osmo_prim to the msgb created by<br>gsm0808 API, but turns out the headroom is too small:<br><br>    msgb(0x61700001b660): Not enough headroom msgb_push (126 < 264)<br><br>Instead of always copying a msgb that has just that instant been created, it<br>makes more sense to allocate sufficient headroom in the first place.<br><br>Change-Id: I95729991eb49555f8bba60c5dc916131b03b6cf2<br>---<br>M include/osmocom/gsm/gsm0808.h<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h</span><br><span>index 35e7a8e..a1345c3 100644</span><br><span>--- a/include/osmocom/gsm/gsm0808.h</span><br><span>+++ b/include/osmocom/gsm/gsm0808.h</span><br><span>@@ -29,8 +29,8 @@</span><br><span> #include <osmocom/gsm/gsm23003.h></span><br><span> #include <osmocom/core/utils.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define BSSMAP_MSG_SIZE 512</span><br><span style="color: hsl(0, 100%, 40%);">-#define BSSMAP_MSG_HEADROOM 128</span><br><span style="color: hsl(120, 100%, 40%);">+#define BSSMAP_MSG_SIZE 1024</span><br><span style="color: hsl(120, 100%, 40%);">+#define BSSMAP_MSG_HEADROOM 512</span><br><span> </span><br><span> struct sockaddr_storage;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13004">change 13004</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13004"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I95729991eb49555f8bba60c5dc916131b03b6cf2 </div>
<div style="display:none"> Gerrit-Change-Number: 13004 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Willmann <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>