<p>Holger Freyther <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13028">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ms_driver: Rename method to hopefully be more clear<br><br>This is finding min/max in a dataset. Call it like this and update<br>the caller.<br><br>Change-Id: Ic7f5cd34639f897e460ca1edcb4f9b6df44683e9<br>---<br>M src/osmo_ms_driver/location_update_test.py<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ms_driver/location_update_test.py b/src/osmo_ms_driver/location_update_test.py</span><br><span>index 90e405e..8500607 100644</span><br><span>--- a/src/osmo_ms_driver/location_update_test.py</span><br><span>+++ b/src/osmo_ms_driver/location_update_test.py</span><br><span>@@ -198,7 +198,7 @@</span><br><span>     def all_completed(self):</span><br><span>         return self._outstanding == 0</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    def results_min_max(self, results):</span><br><span style="color: hsl(120, 100%, 40%);">+    def find_min_max(self, results):</span><br><span>         min_value = max_value = None</span><br><span>         for result in results:</span><br><span>             if min_value is None or result.lu_delay() < min_value:</span><br><span>@@ -209,7 +209,7 @@</span><br><span> </span><br><span>     def print_stats(self):</span><br><span>         all_completed = self.all_completed()</span><br><span style="color: hsl(0, 100%, 40%);">-        min_value, max_value = self.results_min_max(filter(lambda x: x.has_lu_time(), self._results.values()))</span><br><span style="color: hsl(120, 100%, 40%);">+        min_value, max_value = self.find_min_max(filter(lambda x: x.has_lu_time(), self._results.values()))</span><br><span> </span><br><span>         self.log("Tests done", all_completed=all_completed,</span><br><span>                     min=min_value, max=max_value)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13028">change 13028</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13028"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic7f5cd34639f897e460ca1edcb4f9b6df44683e9 </div>
<div style="display:none"> Gerrit-Change-Number: 13028 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>