<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13018">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/msc_vty.c: drop dead comparison against null<br><br>Since vsub->sgs.mme_name is allocated statically, comparing it<br>to null doesn't make sense - it's always != NULL.<br><br>Change-Id: Ib2933a20471ebff9dfe1d9fdddf39d177504c951<br>Fixes: CID#178166 Array compared against 0 (NO_EFFECT)<br>---<br>M src/libmsc/msc_vty.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/18/13018/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index 5aa533b..2adb2a4 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -749,7 +749,7 @@</span><br><span>     /* SGs related */</span><br><span>    vty_out(vty, "    SGs-state: %s%s",</span><br><span>                osmo_fsm_inst_state_name(vsub->sgs_fsm), VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-       if (vsub->sgs.mme_name && strlen(vsub->sgs.mme_name))</span><br><span style="color: hsl(120, 100%, 40%);">+   if (strlen(vsub->sgs.mme_name))</span><br><span>           vty_out(vty, "    SGs-MME: %s%s", vsub->sgs.mme_name, VTY_NEWLINE);</span><br><span>     else</span><br><span>                 vty_out(vty, "    SGs-MME: (none)%s", VTY_NEWLINE);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13018">change 13018</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13018"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib2933a20471ebff9dfe1d9fdddf39d177504c951 </div>
<div style="display:none"> Gerrit-Change-Number: 13018 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>