<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12892">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  daniel: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OML: Don't advertise baseband transceiver as UNLOCKED at startup<br><br>For some strange historical reason, the baseband transceiver MO was<br>brought up in state "UNLOCKED".<br><br>The object should come up in "locked" state until it's explicitly<br>unlocked by the BSC.<br><br>See Section 6.8.2 of TS 12.21: "If there is yet no administrative state<br>value explicitly set by the BSC (e.g., at an initialization time), the<br>object shall be presumed to be administratively locked by default"<br><br>Change-Id: Id505594b9f224567566caac84dae2e2ae4477fae<br>Closes: OS#3790<br>---<br>M src/common/gsm_data_shared.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c</span><br><span>index 58b2503..6703095 100644</span><br><span>--- a/src/common/gsm_data_shared.c</span><br><span>+++ b/src/common/gsm_data_shared.c</span><br><span>@@ -226,8 +226,6 @@</span><br><span> </span><br><span>      gsm_mo_init(&trx->mo, bts, NM_OC_RADIO_CARRIER,</span><br><span>                   bts->nr, trx->nr, 0xff);</span><br><span style="color: hsl(0, 100%, 40%);">-      /* FIXME: Why would the TRX come up unlocked? */</span><br><span style="color: hsl(0, 100%, 40%);">-        trx->mo.nm_state.administrative = NM_STATE_UNLOCKED;</span><br><span> </span><br><span>  gsm_mo_init(&trx->bb_transc.mo, bts, NM_OC_BASEB_TRANSC,</span><br><span>                  bts->nr, trx->nr, 0xff);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12892">change 12892</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12892"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id505594b9f224567566caac84dae2e2ae4477fae </div>
<div style="display:none"> Gerrit-Change-Number: 12892 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>