<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/13004">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13004/1/include/osmocom/gsm/gsm0808.h">File include/osmocom/gsm/gsm0808.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13004/1/include/osmocom/gsm/gsm0808.h@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace">#define BSSMAP_MSG_SIZE (osmo_gsm0808_msg_size ? : BSSMAP_MSG_DEFAULT_SIZE - BSSMAP_MSG_DEFAULT_HEADROOM + BSSMAP_MSG_HEADROOM)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't really understand what you are trying to do here.</p><p style="white-space: pre-wrap; word-wrap: break-word;">It's now possible to allocate less than MSG_DEFAULT_SIZE if you set msg_headroom to something smaller than the default. Is that intentional?</p><p style="white-space: pre-wrap; word-wrap: break-word;">osmo_gsm0808_msg_headroom = 32;<br>-> BSSMAP_MSG_HEADROOM == 32<br>-> BSSMAP_MSG_SIZE == 512 - 128 + 32 == 416</p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you did this to ensure the tailroom doesn't decrease when you increase the headroom, but I think this is a bit strange as BSSMAP_MSG_DEFAULT_SIZE seems to mean how much to allocate for the complete msgb including headroom and now it sort of means how much tailroom you want to have.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Rename the _DEFAULT_ or simplify the define? I'd be fine with either.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13004">change 13004</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13004"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I95729991eb49555f8bba60c5dc916131b03b6cf2 </div>
<div style="display:none"> Gerrit-Change-Number: 13004 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Feb 2019 14:14:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>