<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12926">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">a_iface: use 'const' qualifier for ran_conn whenever possible<br><br>Change-Id: I8a15c9baae2071569e2ecc4635ddaf5a0001f959<br>---<br>M include/osmocom/msc/a_iface.h<br>M src/libmsc/a_iface.c<br>2 files changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/26/12926/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/a_iface.h b/include/osmocom/msc/a_iface.h</span><br><span>index 2d11cca..d8a8aab 100644</span><br><span>--- a/include/osmocom/msc/a_iface.h</span><br><span>+++ b/include/osmocom/msc/a_iface.h</span><br><span>@@ -68,7 +68,7 @@</span><br><span> int a_iface_tx_assignment(const struct gsm_trans *trans);</span><br><span> </span><br><span> /* Send clear command via A-interface */</span><br><span style="color: hsl(0, 100%, 40%);">-int a_iface_tx_clear_cmd(struct ran_conn *conn);</span><br><span style="color: hsl(120, 100%, 40%);">+int a_iface_tx_clear_cmd(const struct ran_conn *conn);</span><br><span> </span><br><span> int a_iface_tx_classmark_request(const struct ran_conn *conn);</span><br><span> </span><br><span>diff --git a/src/libmsc/a_iface.c b/src/libmsc/a_iface.c</span><br><span>index c76e5c5..2c38189 100644</span><br><span>--- a/src/libmsc/a_iface.c</span><br><span>+++ b/src/libmsc/a_iface.c</span><br><span>@@ -154,14 +154,13 @@</span><br><span> /* Send DTAP message via A-interface, take ownership of msg */</span><br><span> int a_iface_tx_dtap(struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       struct ran_conn *conn;</span><br><span style="color: hsl(120, 100%, 40%);">+        const struct ran_conn *conn;</span><br><span>         struct msgb *msg_resp;</span><br><span> </span><br><span>   uint8_t link_id = OMSC_LINKID_CB(msg);</span><br><span>       OSMO_ASSERT(msg);</span><br><span>    conn = (struct ran_conn *)msg->dst;</span><br><span>       OSMO_ASSERT(conn);</span><br><span style="color: hsl(0, 100%, 40%);">-      OSMO_ASSERT(conn->a.scu);</span><br><span> </span><br><span>     LOGPCONN(conn, LOGL_DEBUG, "Passing DTAP message (DLCI=0x%02x) from MSC to BSC\n", link_id);</span><br><span> </span><br><span>@@ -367,7 +366,7 @@</span><br><span> /* Send assignment request via A-interface */</span><br><span> int a_iface_tx_assignment(const struct gsm_trans *trans)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      struct ran_conn *conn;</span><br><span style="color: hsl(120, 100%, 40%);">+        const struct ran_conn *conn;</span><br><span>         struct gsm0808_channel_type ct;</span><br><span>      struct gsm0808_speech_codec_list scl;</span><br><span>        struct msgb *msg;</span><br><span>@@ -418,7 +417,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Send clear command via A-interface */</span><br><span style="color: hsl(0, 100%, 40%);">-int a_iface_tx_clear_cmd(struct ran_conn *conn)</span><br><span style="color: hsl(120, 100%, 40%);">+int a_iface_tx_clear_cmd(const struct ran_conn *conn)</span><br><span> {</span><br><span>      struct msgb *msg;</span><br><span>    struct vlr_subscr *vsub = conn->vsub;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12926">change 12926</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12926"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8a15c9baae2071569e2ecc4635ddaf5a0001f959 </div>
<div style="display:none"> Gerrit-Change-Number: 12926 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>