<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12933">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808: Add unit tests for test_create_clear_command2()<br><br>Change-Id: Ie3f34b78edc91a013152742bebbd839586a787fe<br>Related: OS#3805<br>---<br>M tests/gsm0808/gsm0808_test.c<br>M tests/gsm0808/gsm0808_test.ok<br>2 files changed, 26 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c</span><br><span>index f06e8b7..65fef53 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.c</span><br><span>+++ b/tests/gsm0808/gsm0808_test.c</span><br><span>@@ -186,6 +186,28 @@</span><br><span>     msgb_free(msg);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void test_create_clear_command2()</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ static const uint8_t res[] = { 0x00, 0x04, 0x20, 0x04, 0x01, 0x23 };</span><br><span style="color: hsl(120, 100%, 40%);">+  struct msgb *msg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   printf("Testing creating Clear Command 2\n");</span><br><span style="color: hsl(120, 100%, 40%);">+       msg = gsm0808_create_clear_command2(0x23, false);</span><br><span style="color: hsl(120, 100%, 40%);">+     VERIFY(msg, res, ARRAY_SIZE(res));</span><br><span style="color: hsl(120, 100%, 40%);">+    msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void test_create_clear_command2_csfb()</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        static const uint8_t res[] = { 0x00, 0x05, 0x20, 0x04, 0x01, 0x23, 0x8F };</span><br><span style="color: hsl(120, 100%, 40%);">+    struct msgb *msg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   printf("Testing creating Clear Command 2 (CSFB)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+        msg = gsm0808_create_clear_command2(0x23, true);</span><br><span style="color: hsl(120, 100%, 40%);">+      VERIFY(msg, res, ARRAY_SIZE(res));</span><br><span style="color: hsl(120, 100%, 40%);">+    msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void test_create_clear_complete()</span><br><span> {</span><br><span>        static const uint8_t res[] = { 0x00, 0x01, 0x21 };</span><br><span>@@ -2219,6 +2241,8 @@</span><br><span>   test_create_reset();</span><br><span>         test_create_reset_ack();</span><br><span>     test_create_clear_command();</span><br><span style="color: hsl(120, 100%, 40%);">+  test_create_clear_command2();</span><br><span style="color: hsl(120, 100%, 40%);">+ test_create_clear_command2_csfb();</span><br><span>   test_create_clear_complete();</span><br><span>        test_create_cipher();</span><br><span>        test_create_cipher_complete();</span><br><span>diff --git a/tests/gsm0808/gsm0808_test.ok b/tests/gsm0808/gsm0808_test.ok</span><br><span>index aae8959..7819e7a 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.ok</span><br><span>+++ b/tests/gsm0808/gsm0808_test.ok</span><br><span>@@ -6,6 +6,8 @@</span><br><span> Testing creating Reset</span><br><span> Testing creating Reset Ack</span><br><span> Testing creating Clear Command</span><br><span style="color: hsl(120, 100%, 40%);">+Testing creating Clear Command 2</span><br><span style="color: hsl(120, 100%, 40%);">+Testing creating Clear Command 2 (CSFB)</span><br><span> Testing creating Clear Complete</span><br><span> Testing creating Chipher Mode Command</span><br><span> Testing creating Cipher Complete</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12933">change 12933</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12933"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie3f34b78edc91a013152742bebbd839586a787fe </div>
<div style="display:none"> Gerrit-Change-Number: 12933 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>