<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12895">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">GMM: permit VLR_ANSWERED event in attach FSM<br><br>This fixes following error:<br>DMM gprs_gmm.c:1126<br>    GMM_ATTACH_REQ_FSM(gb_gmm_req)[0x5589e78dded0]{WaitAttachComplete}:<br>   Event VLR answered not permitted<br><br>There seems to be a race condition in FSM when MS establishes MM context<br>which isn't immediately followed up by PDP context (for example when no<br>APN is configured in MS).<br><br>This does not affect actual functionality because in this case MS won't<br>be able to use GPRS anyway but it's still nice to get our FSM fixed even<br>in this corner case.<br><br>Change-Id: I14d234632224e20faf865d2273c83cfff31abf61<br>---<br>M src/gprs/gprs_gmm_attach.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm_attach.c b/src/gprs/gprs_gmm_attach.c</span><br><span>index 6fdb3af..1ab11f7 100644</span><br><span>--- a/src/gprs/gprs_gmm_attach.c</span><br><span>+++ b/src/gprs/gprs_gmm_attach.c</span><br><span>@@ -195,6 +195,12 @@</span><br><span>                extract_subscr_hlr(ctx);</span><br><span>             osmo_fsm_inst_state_chg(fi, ST_INIT, 0, 0);</span><br><span>          break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case E_VLR_ANSWERED:</span><br><span style="color: hsl(120, 100%, 40%);">+          extract_subscr_msisdn(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+           extract_subscr_hlr(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGMMCTXP(LOGL_NOTICE, ctx,</span><br><span style="color: hsl(120, 100%, 40%);">+                     "Unusual event: if MS got no data connection, check that it has APN configured.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span>       }</span><br><span> }</span><br><span> </span><br><span>@@ -295,7 +301,7 @@</span><br><span>             .action = st_iu_security_cmd,</span><br><span>        },</span><br><span>   [ST_ACCEPT] = {</span><br><span style="color: hsl(0, 100%, 40%);">-         .in_event_mask = X(E_ATTACH_COMPLETE_RECV),</span><br><span style="color: hsl(120, 100%, 40%);">+           .in_event_mask = X(E_ATTACH_COMPLETE_RECV) | X(E_VLR_ANSWERED),</span><br><span>              .out_state_mask = X(ST_INIT) | X(ST_REJECT),</span><br><span>                 .name = "WaitAttachComplete",</span><br><span>              .onenter = st_accept_on_enter,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12895">change 12895</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12895"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I14d234632224e20faf865d2273c83cfff31abf61 </div>
<div style="display:none"> Gerrit-Change-Number: 12895 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: lynxis lazus <lynxis@fe80.eu> </div>