<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12869">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OML: Report short messages even for invalid TRX numbers in down_fom()<br><br>Change-Id: I65b57d3fc714814db3ae3fd34398f307413fece8<br>---<br>M src/common/oml.c<br>1 file changed, 3 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/69/12869/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index cbd2e1b..a3227f5 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -1093,12 +1093,10 @@</span><br><span>    int ret;</span><br><span> </span><br><span>         if (msgb_l2len(msg) < sizeof(*foh)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DOML, LOGL_NOTICE, "Formatted O&M message too short\n");</span><br><span>          trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr);</span><br><span style="color: hsl(0, 100%, 40%);">-            if (trx) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MAJ_UKWN_MSG,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                 "Formatted O&M message too short");</span><br><span style="color: hsl(0, 100%, 40%);">-              }</span><br><span style="color: hsl(120, 100%, 40%);">+             if (trx)</span><br><span style="color: hsl(120, 100%, 40%);">+                      mo = &trx->mo;</span><br><span style="color: hsl(120, 100%, 40%);">+         oml_tx_failure_event_rep(mo, OSMO_EVT_MAJ_UKWN_MSG, "Formatted O&M message too short");</span><br><span>                return -EIO;</span><br><span>         }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12869">change 12869</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12869"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I65b57d3fc714814db3ae3fd34398f307413fece8 </div>
<div style="display:none"> Gerrit-Change-Number: 12869 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>