<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12864">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OML: Ensure MOs are initialized with valid "Administrative State'<br><br>When osmo-bts connects to the BSC, it sends a ton of "State Change Event<br>Report" messages indicating the Operational State (NULL), Availability<br>status (power off) and [as an osmocom extension] also the Administrative<br>State. However, the value of the administrative state is "0", which is<br>not defined in TS 12.21 Section 9.4.4<br><br>Change-Id: I03f8a4b08b266cd40036076c76f9dc7e8bf08da2<br>Closes: OS#3785<br>---<br>M src/common/gsm_data_shared.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/12864/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c</span><br><span>index 2d9af78..58b2503 100644</span><br><span>--- a/src/common/gsm_data_shared.c</span><br><span>+++ b/src/common/gsm_data_shared.c</span><br><span>@@ -38,6 +38,7 @@</span><br><span> {</span><br><span>   mo->nm_state.operational = NM_OPSTATE_NULL;</span><br><span>       mo->nm_state.availability = NM_AVSTATE_POWER_OFF;</span><br><span style="color: hsl(120, 100%, 40%);">+  mo->nm_state.administrative = NM_STATE_LOCKED;</span><br><span> }</span><br><span> </span><br><span> static void gsm_mo_init(struct gsm_abis_mo *mo, struct gsm_bts *bts,</span><br><span>@@ -222,10 +223,12 @@</span><br><span> </span><br><span>       trx->bts = bts;</span><br><span>   trx->nr = bts->num_trx++;</span><br><span style="color: hsl(0, 100%, 40%);">- trx->mo.nm_state.administrative = NM_STATE_UNLOCKED;</span><br><span> </span><br><span>  gsm_mo_init(&trx->mo, bts, NM_OC_RADIO_CARRIER,</span><br><span>                   bts->nr, trx->nr, 0xff);</span><br><span style="color: hsl(120, 100%, 40%);">+    /* FIXME: Why would the TRX come up unlocked? */</span><br><span style="color: hsl(120, 100%, 40%);">+      trx->mo.nm_state.administrative = NM_STATE_UNLOCKED;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    gsm_mo_init(&trx->bb_transc.mo, bts, NM_OC_BASEB_TRANSC,</span><br><span>                  bts->nr, trx->nr, 0xff);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12864">change 12864</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12864"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I03f8a4b08b266cd40036076c76f9dc7e8bf08da2 </div>
<div style="display:none"> Gerrit-Change-Number: 12864 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>