<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12840">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_04_80.c: use gsm0480_create_release_complete()<br><br>The previous implementation of msc_send_ussd_release_complete() was<br>based on gsm0480_create_ussd_release_complete(), that doesn't<br>allow to specify GSM 04.07 transaction identifier.<br><br>The ability to specify particular transaction identifier<br>is required for handling multiple SS/USSD transactions.<br><br>Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb<br>---<br>M include/osmocom/msc/gsm_04_80.h<br>M src/libmsc/gsm_04_80.c<br>M src/libmsc/msc_vty.c<br>3 files changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/12840/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/gsm_04_80.h b/include/osmocom/msc/gsm_04_80.h</span><br><span>index 29b800b..0008c22 100644</span><br><span>--- a/include/osmocom/msc/gsm_04_80.h</span><br><span>+++ b/include/osmocom/msc/gsm_04_80.h</span><br><span>@@ -10,4 +10,5 @@</span><br><span> </span><br><span> int msc_send_ussd_notify(struct ran_conn *conn, int level,</span><br><span>                         const char *text);</span><br><span style="color: hsl(0, 100%, 40%);">-int msc_send_ussd_release_complete(struct ran_conn *conn);</span><br><span style="color: hsl(120, 100%, 40%);">+int msc_send_ussd_release_complete(struct ran_conn *conn,</span><br><span style="color: hsl(120, 100%, 40%);">+                                 uint8_t transaction_id)</span><br><span>diff --git a/src/libmsc/gsm_04_80.c b/src/libmsc/gsm_04_80.c</span><br><span>index 119f0e1..502848f 100644</span><br><span>--- a/src/libmsc/gsm_04_80.c</span><br><span>+++ b/src/libmsc/gsm_04_80.c</span><br><span>@@ -78,9 +78,10 @@</span><br><span>         return msc_tx_dtap(conn, msg);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int msc_send_ussd_release_complete(struct ran_conn *conn)</span><br><span style="color: hsl(120, 100%, 40%);">+int msc_send_ussd_release_complete(struct ran_conn *conn,</span><br><span style="color: hsl(120, 100%, 40%);">+                              uint8_t transaction_id)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *msg = gsm0480_create_ussd_release_complete();</span><br><span style="color: hsl(120, 100%, 40%);">+    struct msgb *msg = gsm0480_create_release_complete(transaction_id);</span><br><span>  if (!msg)</span><br><span>            return -1;</span><br><span>   return msc_tx_dtap(conn, msg);</span><br><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index e1019a2..078b83a 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -1149,7 +1149,9 @@</span><br><span>  }</span><br><span> </span><br><span>        msc_send_ussd_notify(conn, level, text);</span><br><span style="color: hsl(0, 100%, 40%);">-        msc_send_ussd_release_complete(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: since we don't allocate a transaction here,</span><br><span style="color: hsl(120, 100%, 40%);">+      * we use dummy GSM 04.07 transaction ID. */</span><br><span style="color: hsl(120, 100%, 40%);">+  msc_send_ussd_release_complete(conn, 0x00);</span><br><span> </span><br><span>      vlr_subscr_put(vsub);</span><br><span>        talloc_free(text);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12840">change 12840</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12840"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id2975c3383f18e83124ba38927c03980d67ddadb </div>
<div style="display:none"> Gerrit-Change-Number: 12840 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>