<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12775">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">doxygen: add source files as dependencies<br><br>So far, when modifying a source file, the doxygen docs were not regenerated<br>automatically. It required a manual 'rm -rf docs/core' or similar. Make it<br>rebuild automatically:<br><br>Add each library's source files to the list of dependencies for the first-pass<br>doxygen build.<br><br>Attention, since all libraries depend on the .map files of each other library,<br>and each library depends on its own source files, that means that a single<br>touch on one .c file anywhere will result in rebuilding the entire doxygen<br>docs. It is correct to do so, since any file may introduce \ref targets used<br>anywhere else. If you don't want that, --disable-doxygen.<br><br>Change-Id: I15ea96be6e7abe91264b91f0b06963a0f2d63b0b<br>---<br>M Makefile.am<br>1 file changed, 25 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile.am b/Makefile.am</span><br><span>index 9e0888f..8fe5f57 100644</span><br><span>--- a/Makefile.am</span><br><span>+++ b/Makefile.am</span><br><span>@@ -51,43 +51,61 @@</span><br><span> # circular dependency: we would rebuild all every time 'make' is invoked.</span><br><span> # The .prep file also depends on all the source files for that library.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(top_builddir)/doc/libosmocore.tag.prep: $(top_builddir)/Doxyfile.core</span><br><span style="color: hsl(120, 100%, 40%);">+$(top_builddir)/doc/libosmocore.tag.prep: $(top_builddir)/Doxyfile.core \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/core/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/*.[hc] \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/pseudotalloc/*.[hc]</span><br><span> rm -rf $(top_builddir)/doc/core; mkdir -p $(top_builddir)/doc/core</span><br><span> rm -rf $(top_builddir)/doc/libosmocore.map</span><br><span> -$(DOXYGEN) $(top_builddir)/Doxyfile.core</span><br><span> touch "$@"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(top_builddir)/doc/libosmogsm.tag.prep: $(top_builddir)/Doxyfile.gsm</span><br><span style="color: hsl(120, 100%, 40%);">+$(top_builddir)/doc/libosmogsm.tag.prep: $(top_builddir)/Doxyfile.gsm \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/gsm/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/gsm/protocol/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/crypt/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/gsm/*.c \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/gsm/milenage/*.[hc]</span><br><span> rm -rf $(top_builddir)/doc/gsm; mkdir -p $(top_builddir)/doc/gsm</span><br><span> rm -rf $(top_builddir)/doc/libosmogsm.map</span><br><span> -$(DOXYGEN) $(top_builddir)/Doxyfile.gsm</span><br><span> touch "$@"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(top_builddir)/doc/libosmovty.tag.prep: $(top_builddir)/Doxyfile.vty</span><br><span style="color: hsl(120, 100%, 40%);">+$(top_builddir)/doc/libosmovty.tag.prep: $(top_builddir)/Doxyfile.vty \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/vty/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/vty/*.c</span><br><span> rm -rf $(top_builddir)/doc/vty; mkdir -p $(top_builddir)/doc/vty</span><br><span> rm -rf $(top_builddir)/doc/libosmovty.map</span><br><span> -$(DOXYGEN) $(top_builddir)/Doxyfile.vty</span><br><span> touch "$@"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(top_builddir)/doc/libosmocodec.tag.prep: $(top_builddir)/Doxyfile.codec</span><br><span style="color: hsl(120, 100%, 40%);">+$(top_builddir)/doc/libosmocodec.tag.prep: $(top_builddir)/Doxyfile.codec \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/codec/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/codec/*.c</span><br><span> rm -rf $(top_builddir)/doc/codec; mkdir -p $(top_builddir)/doc/codec</span><br><span> rm -rf $(top_builddir)/doc/libosmocodec.map</span><br><span> -$(DOXYGEN) $(top_builddir)/Doxyfile.codec</span><br><span> touch "$@"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(top_builddir)/doc/libosmocoding.tag.prep: $(top_builddir)/Doxyfile.coding</span><br><span style="color: hsl(120, 100%, 40%);">+$(top_builddir)/doc/libosmocoding.tag.prep: $(top_builddir)/Doxyfile.coding \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/coding/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/coding/*.c</span><br><span> rm -rf $(top_builddir)/doc/coding; mkdir -p $(top_builddir)/doc/coding</span><br><span> rm -rf $(top_builddir)/doc/libosmocoding.map</span><br><span> -$(DOXYGEN) $(top_builddir)/Doxyfile.coding</span><br><span> touch "$@"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(top_builddir)/doc/libosmoctrl.tag.prep: $(top_builddir)/Doxyfile.ctrl</span><br><span style="color: hsl(120, 100%, 40%);">+$(top_builddir)/doc/libosmoctrl.tag.prep: $(top_builddir)/Doxyfile.ctrl \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/ctrl/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/ctrl/*.c</span><br><span> rm -rf $(top_builddir)/doc/ctrl; mkdir -p $(top_builddir)/doc/ctrl</span><br><span> rm -rf $(top_builddir)/doc/libosmoctrl.map</span><br><span> -$(DOXYGEN) $(top_builddir)/Doxyfile.ctrl</span><br><span> touch "$@"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-$(top_builddir)/doc/libosmogb.tag.prep: $(top_builddir)/Doxyfile.gb</span><br><span style="color: hsl(120, 100%, 40%);">+$(top_builddir)/doc/libosmogb.tag.prep: $(top_builddir)/Doxyfile.gb \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/include/osmocom/gprs/*.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(top_srcdir)/src/gb/*.[hc]</span><br><span> rm -rf $(top_builddir)/doc/gb; mkdir -p $(top_builddir)/doc/gb</span><br><span> rm -rf $(top_builddir)/doc/libosmogb.map</span><br><span> -$(DOXYGEN) $(top_builddir)/Doxyfile.gb</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12775">change 12775</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12775"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I15ea96be6e7abe91264b91f0b06963a0f2d63b0b </div>
<div style="display:none"> Gerrit-Change-Number: 12775 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>