<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12782">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile/gsm322.c: fix: properly print stored BA list entities<br><br>As we do iterate over all entities in the BA list, it makes more<br>sense to print each one separately instead of printing the last<br>one. Moreover, as soon as the iteration is finished, *ba points<br>to some zero-initialized part of memory:<br><br>  gsm322.c:5170 Write stored BA list (mcc=000 mnc=000  Marshall Islands, 000)<br><br>After this patch:<br><br>  gsm322.c:5162 Write stored BA list (mcc=250 mnc=99  Russian Federation, Beeline)<br>  gsm322.c:5162 Write stored BA list (mcc=250 mnc=01  Russian Federation, MegaFon)<br>  gsm322.c:5162 Write stored BA list (mcc=250 mnc=02  Russian Federation, MTS)<br>  gsm322.c:5162 Write stored BA list (mcc=544 mnc=31  Serbia, Telenor)<br><br>Change-Id: I5160492e6125401c6a1765f54d129b1f1cd503fc<br>---<br>M src/host/layer23/src/mobile/gsm322.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/82/12782/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c</span><br><span>index f2b51df..7da63e3 100644</span><br><span>--- a/src/host/layer23/src/mobile/gsm322.c</span><br><span>+++ b/src/host/layer23/src/mobile/gsm322.c</span><br><span>@@ -5156,6 +5156,11 @@</span><br><span>                             buf[2] = ba->mnc >> 8;</span><br><span>                              buf[3] = ba->mnc & 0xff;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+                           LOGP(DCS, LOGL_INFO, "Write stored BA list (mcc=%s "</span><br><span style="color: hsl(120, 100%, 40%);">+                                        "mnc=%s  %s, %s)\n", gsm_print_mcc(ba->mcc),</span><br><span style="color: hsl(120, 100%, 40%);">+                                     gsm_print_mnc(ba->mnc), gsm_get_mcc(ba->mcc),</span><br><span style="color: hsl(120, 100%, 40%);">+                                   gsm_get_mnc(ba->mcc, ba->mnc));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                              rc += fwrite(buf, 4, 1, fp);</span><br><span>                                 rc += fwrite(ba->freq, sizeof(ba->freq), 1, fp);</span><br><span>                       }</span><br><span>@@ -5163,12 +5168,7 @@</span><br><span>           }</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (rc == 2)</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGP(DCS, LOGL_INFO, "Write stored BA list (mcc=%s "</span><br><span style="color: hsl(0, 100%, 40%);">-                  "mnc=%s  %s, %s)\n", gsm_print_mcc(ba->mcc),</span><br><span style="color: hsl(0, 100%, 40%);">-                       gsm_print_mnc(ba->mnc), gsm_get_mcc(ba->mcc),</span><br><span style="color: hsl(0, 100%, 40%);">-                     gsm_get_mnc(ba->mcc, ba->mnc));</span><br><span style="color: hsl(0, 100%, 40%);">-   else</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rc != 2)</span><br><span>                 LOGP(DCS, LOGL_ERROR, "Failed to write BA list\n");</span><br><span> </span><br><span>    /* free lists */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12782">change 12782</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12782"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5160492e6125401c6a1765f54d129b1f1cd503fc </div>
<div style="display:none"> Gerrit-Change-Number: 12782 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>