<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12687">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_04_11.c: also assign SM-RP-MR to MO transactions<br><br>Previously, SM-RP Message Reference was assigned to MT transactions<br>only, but not to MO transactions. As a result, this could lead to<br>having a few transactions with duplicate SM-RP-MR value, because<br>in case of MO SMS, trans->sms.sm_rp_mr would remain 0x00.<br><br>Let's parse SM-RP-MR from MO SMS messages in gsm0411_rcv_sms(),<br>and assign it to the new transaction after allocation.<br><br>Change-Id: I4d07354175444f9764fb0dd6ea188a64494d79fe<br>---<br>M src/libmsc/gsm_04_11.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c</span><br><span>index 4dc07bd..2f39b06 100644</span><br><span>--- a/src/libmsc/gsm_04_11.c</span><br><span>+++ b/src/libmsc/gsm_04_11.c</span><br><span>@@ -1179,6 +1179,7 @@</span><br><span>   struct gsm48_hdr *gh = msgb_l3(msg);</span><br><span>         uint8_t msg_type = gh->msg_type;</span><br><span>  uint8_t transaction_id = gsm48_hdr_trans_id_flip_ti(gh);</span><br><span style="color: hsl(120, 100%, 40%);">+      struct gsm411_rp_hdr *rph = (struct gsm411_rp_hdr *) gh->data;</span><br><span>    struct gsm_trans *trans;</span><br><span>     int new_trans = 0;</span><br><span>   int rc = 0;</span><br><span>@@ -1210,6 +1211,7 @@</span><br><span>                  return -ENOMEM;</span><br><span>              }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         trans->sms.sm_rp_mr = rph->msg_ref; /* SM-RP Message Reference */</span><br><span>              trans->dlci = OMSC_LINKID_CB(msg); /* DLCI as received from BSC */</span><br><span> </span><br><span>            new_trans = 1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12687">change 12687</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12687"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4d07354175444f9764fb0dd6ea188a64494d79fe </div>
<div style="display:none"> Gerrit-Change-Number: 12687 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>