<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12627">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_Tests.ttcn: introduce TC_gsup_mt_sms_rp_mr<br><br>The idea of this test case is to verify SM-RP-MR assignment for<br>a few MT SMS being sent over GSUP. Basically, the algorythm is<br>the following:<br><br> 1.0 send the 1st SMS using MT-ForwardSM-Req on GSUP,<br> 1.1 expect Paging Request on RAN,<br> 1.2 establish a RAN connection,<br> 1.3 expect CP-DATA/RP-DATA for the 1st SMS,<br><br> 2.0 send the 2nd SMS using MT-ForwardSM-Req on GSUP,<br> 2.1 expect CP-DATA/RP-DATA for the 2nd SMS,<br><br> 3.0 compare both SM-RP-MR values assigned by the MSC,<br> 3.1 send CP-DATA/RP-ACK for both 1st and 2nd SMS messages,<br> 3.2 expect MT-ForwardSM-Res for both 1st and 2nd SMS messages.<br><br>The SM-RP-MR values for both 1st and 2nd messages shall not match.<br><br>Change-Id: I3a52d44f4abde9b6b471b9108c1cee905884c9bc<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/expected-results.xml<br>2 files changed, 114 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index a8f37bd..fb0798c 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -2409,6 +2409,118 @@</span><br><span> f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test SM-RP-MR assignment for MT-SMS over GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_gsup_mt_sms_rp_mr(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SmsParameters spars1 := valueof(t_SmsPars); /* 1st SMS */</span><br><span style="color: hsl(120, 100%, 40%);">+ var SmsParameters spars2 := valueof(t_SmsPars); /* 2nd SMS */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We need to inspect GSUP activity */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Perform location update */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Register an 'expect' for given IMSI (+TMSI) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (isvalue(g_pars.tmsi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, g_pars.tmsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, 'FFFFFFFF'O);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Submit the 1st MT SMS on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TX MT-forwardSM-Req for the 1st SMS");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gsup_forwardSM_req(spars1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect Paging Request and Establish DTAP / BSSAP / SCCP connection */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(EST_TYPE_PAG_RESP);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait for 1st MT SMS on DTAP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_expect(spars1);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX the 1st SMS on DTAP, DTAP TID is ", spars1.tid,</span><br><span style="color: hsl(120, 100%, 40%);">+ ", SM-RP-MR is ", spars1.rp.msg_ref);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Submit the 2nd MT SMS on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ log("TX MT-forwardSM-Req for the 2nd SMS");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gsup_forwardSM_req(spars2);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait for 2nd MT SMS on DTAP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_expect(spars2);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX the 2nd SMS on DTAP, DTAP TID is ", spars2.tid,</span><br><span style="color: hsl(120, 100%, 40%);">+ ", SM-RP-MR is ", spars2.rp.msg_ref);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Both transaction IDs shall be different */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (spars1.tid == spars2.tid) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Both DTAP transaction IDs shall be different");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Both SM-RP-MR values shall be different */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (spars1.rp.msg_ref == spars2.rp.msg_ref) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Both SM-RP-MR values shall be different");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Both SM-RP-MR values shall be assigned */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (spars1.rp.msg_ref == 'FF'O) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Unassigned SM-RP-MR value for the 1st SMS");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (spars2.rp.msg_ref == 'FF'O) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Unassigned SM-RP-MR value for the 2nd SMS");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send the 1st RP-ACK and expect MT-forwardSM-Res on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_send_rp_ack(spars1);</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_RES(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := spars1.rp.msg_ref</span><br><span style="color: hsl(120, 100%, 40%);">+ )) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX MT-forwardSM-Res (RP-ACK)");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX unexpected GSUP message");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send the 2nd RP-ACK and expect MT-forwardSM-Res on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_send_rp_ack(spars2);</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_RES(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := spars2.rp.msg_ref</span><br><span style="color: hsl(120, 100%, 40%);">+ )) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX MT-forwardSM-Res (RP-ACK)");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX unexpected GSUP message");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_gsup_mt_sms_rp_mr() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := f_init_pars(92);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler_with_pars(refers(f_tc_gsup_mt_sms_rp_mr), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Test multi-part MT-SMS over GSUP */</span><br><span> private function f_tc_gsup_mt_multi_part_sms(charstring id, BSC_ConnHdlrPars pars)</span><br><span> runs on BSC_ConnHdlr {</span><br><span>@@ -4344,6 +4456,7 @@</span><br><span> execute( TC_gsup_mo_smma() );</span><br><span> execute( TC_gsup_mt_sms_ack() );</span><br><span> execute( TC_gsup_mt_sms_err() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_gsup_mt_sms_rp_mr() );</span><br><span> execute( TC_gsup_mt_multi_part_sms() );</span><br><span> </span><br><span> execute( TC_lu_and_mo_ussd_single_request() );</span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index aeb2d24..84df264 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -58,6 +58,7 @@</span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mo_smma' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_ack' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_err' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_rp_mr' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mt_multi_part_sms' time='MASKED'></span><br><span> <failure type='fail-verdict'>Tguard timeout</span><br><span> MSC_Tests.ttcn:MASKED MSC_Tests control part</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12627">change 12627</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12627"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3a52d44f4abde9b6b471b9108c1cee905884c9bc </div>
<div style="display:none"> Gerrit-Change-Number: 12627 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>