<p>dexter <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12684">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Kévin Redon: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Check return code of u.authenticate()<br><br>The method authenticate() of the class USIM may return None in some<br>error cases. Lets check this fore passing the return code into len()<br><br>Change-Id: Ic22f37931c13e7ec8bd1fa7872cd2a24faeea0ba<br>Related: OS#1967<br>---<br>M osmo-sim-auth.py<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osmo-sim-auth.py b/osmo-sim-auth.py</span><br><span>index 89deac4..6ba9557 100755</span><br><span>--- a/osmo-sim-auth.py</span><br><span>+++ b/osmo-sim-auth.py</span><br><span>@@ -41,6 +41,9 @@</span><br><span> </span><br><span>         print "\nUMTS Authentication"</span><br><span>      ret = u.authenticate(rand_bin, autn_bin, ctx='3G')</span><br><span style="color: hsl(120, 100%, 40%);">+        if ret == None:</span><br><span style="color: hsl(120, 100%, 40%);">+                print "UMTS Authentication failed"</span><br><span style="color: hsl(120, 100%, 40%);">+                exit(1)</span><br><span>   if len(ret) == 1:</span><br><span>            print "AUTS:\t%s" % b2a_hex(byteToString(ret[0]))</span><br><span>  else:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12684">change 12684</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12684"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sim-auth </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic22f37931c13e7ec8bd1fa7872cd2a24faeea0ba </div>
<div style="display:none"> Gerrit-Change-Number: 12684 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Max <msuraev@sysmocom.de> </div>