<p><a href="https://gerrit.osmocom.org/12706">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c">File src/mncc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c@795">Patch Set #5, Line 795:</a> <code style="font-family:monospace,monospace">osmo_strlcpy</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">OSMO_STRLCPY_ARRAY(mncc.calling.number, call->source +1)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c@798">Patch Set #5, Line 798:</a> <code style="font-family:monospace,monospace">             osmo_strlcpy(mncc.calling.number, call->source, sizeof(mncc.calling.number));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same here. avoids the sizeof, the macro takes care of it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12706">change 12706</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12706"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idcfa31aff90e04dd0aa3583957f288889b1bbefe </div>
<div style="display:none"> Gerrit-Change-Number: 12706 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 29 Jan 2019 12:38:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>