<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12711">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Build shared source as conveniency library<br><br>The simple_ctrl.c is used by 2 independent binaries. Let's build it as a<br>convenience libtool library [1] to make it easier to add further<br>external dependencies in future.<br><br>[1] https://www.gnu.org/software/automake/manual/html_node/Libtool-Convenience-Libraries.html<br><br>Change-Id: Idfaba17b54983709278e1c24bf55edbbb4abd961<br>---<br>M .gitignore<br>M src/Makefile.am<br>2 files changed, 6 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/11/12711/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/.gitignore b/.gitignore</span><br><span>index c89e9b0..e68f4e2 100644</span><br><span>--- a/.gitignore</span><br><span>+++ b/.gitignore</span><br><span>@@ -59,3 +59,4 @@</span><br><span> tests/testsuite.log</span><br><span> </span><br><span> writtenconfig/</span><br><span style="color: hsl(120, 100%, 40%);">+/src/libctrl.la</span><br><span>diff --git a/src/Makefile.am b/src/Makefile.am</span><br><span>index 412337b..ed0f3a0 100644</span><br><span>--- a/src/Makefile.am</span><br><span>+++ b/src/Makefile.am</span><br><span>@@ -1,4 +1,4 @@</span><br><span style="color: hsl(0, 100%, 40%);">-LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS)</span><br><span style="color: hsl(120, 100%, 40%);">+LDADD = libctrl.la $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS)</span><br><span> </span><br><span> AM_CPPFLAGS = \</span><br><span>       $(all_includes) \</span><br><span>@@ -22,6 +22,10 @@</span><br><span>       osmo-ctrl-client \</span><br><span>   $(NULL)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+noinst_LTLIBRARIES = libctrl.la</span><br><span style="color: hsl(120, 100%, 40%);">+libctrl_la_SOURCES = simple_ctrl.c</span><br><span style="color: hsl(120, 100%, 40%);">+libctrl_la_LIBADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> osmo_sysmon_LDADD = $(LDADD) \</span><br><span>     $(LIBOSMOVTY_LIBS) \</span><br><span>         $(LIBMNL_LIBS) \</span><br><span>@@ -29,7 +33,6 @@</span><br><span> </span><br><span> osmo_sysmon_SOURCES = \</span><br><span>  value_node.c \</span><br><span style="color: hsl(0, 100%, 40%);">-  simple_ctrl.c \</span><br><span>      osysmon_ctrl.c \</span><br><span>     osysmon_sysinfo.c \</span><br><span>  osysmon_rtnl.c \</span><br><span>@@ -37,11 +40,6 @@</span><br><span>        osysmon_main.c \</span><br><span>     $(NULL)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-osmo_ctrl_client_SOURCES = \</span><br><span style="color: hsl(0, 100%, 40%);">- simple_ctrl.c \</span><br><span style="color: hsl(0, 100%, 40%);">- osmo-ctrl-client.c \</span><br><span style="color: hsl(0, 100%, 40%);">-    $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> noinst_HEADERS = \</span><br><span>        osysmon.h \</span><br><span>  simple_ctrl.h \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12711">change 12711</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12711"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sysmon </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Idfaba17b54983709278e1c24bf55edbbb4abd961 </div>
<div style="display:none"> Gerrit-Change-Number: 12711 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>