<p>dexter <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12622">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved

Objections:
  Neels Hofmeyr: I would prefer this is not merged as is

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan_select: dont allow half rate EFR to be selected<br><br>The function lchan_select_by_chan_mode() is prone to select an half rate<br>lchan when EFR is used, even though EFR is not defined for half-rate.<br>Lets protect against that.<br><br>Change-Id: I961d9aaba81424053ab1dc04ce7799e716af4cd8<br>Related: OS#3503<br>---<br>M src/osmo-bsc/lchan_select.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c</span><br><span>index f70ad4a..b63dcd2 100644</span><br><span>--- a/src/osmo-bsc/lchan_select.c</span><br><span>+++ b/src/osmo-bsc/lchan_select.c</span><br><span>@@ -136,8 +136,12 @@</span><br><span>  case GSM48_CMODE_SIGN:</span><br><span>               type = GSM_LCHAN_SDCCH;</span><br><span>              break;</span><br><span style="color: hsl(0, 100%, 40%);">-  case GSM48_CMODE_SPEECH_V1:</span><br><span>  case GSM48_CMODE_SPEECH_EFR:</span><br><span style="color: hsl(120, 100%, 40%);">+          /* EFR works over FR channels only */</span><br><span style="color: hsl(120, 100%, 40%);">+         if (!full_rate)</span><br><span style="color: hsl(120, 100%, 40%);">+                       return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+          /* fall through */</span><br><span style="color: hsl(120, 100%, 40%);">+    case GSM48_CMODE_SPEECH_V1:</span><br><span>  case GSM48_CMODE_SPEECH_AMR:</span><br><span>                 type = full_rate ? GSM_LCHAN_TCH_F : GSM_LCHAN_TCH_H;</span><br><span>                break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12622">change 12622</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12622"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I961d9aaba81424053ab1dc04ce7799e716af4cd8 </div>
<div style="display:none"> Gerrit-Change-Number: 12622 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>