<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12642">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0408_test: Fix IMEI-SV related tests to use no more than 16 digits<br><br>The IMEI-SV is speified as a 16 digit number: 14 digits of IMEI plus<br>two digits of software version.  Let's not try to feed 18 digit long<br>numbers into our functions, as the resulting behavior is unspecified.<br><br>Change-Id: I6fb85a0516dc387902ad9de4fe8c1ba82d68cae6<br>---<br>M tests/gsm0408/gsm0408_test.c<br>M tests/gsm0408/gsm0408_test.ok<br>2 files changed, 16 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/12642/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c</span><br><span>index 6902e8e..2d60b84 100644</span><br><span>--- a/tests/gsm0408/gsm0408_test.c</span><br><span>+++ b/tests/gsm0408/gsm0408_test.c</span><br><span>@@ -422,17 +422,17 @@</span><br><span>  },</span><br><span>   {</span><br><span>            .mi_type = GSM_MI_TYPE_IMEISV,</span><br><span style="color: hsl(0, 100%, 40%);">-          .mi_str = "987654321098765432",</span><br><span style="color: hsl(0, 100%, 40%);">-               .mi_name = "IMEI-SV-987654321098765432",</span><br><span style="color: hsl(0, 100%, 40%);">-              .expect_mi_tlv_hex = "170a937856341290785634f2",</span><br><span style="color: hsl(120, 100%, 40%);">+            .mi_str = "9876543210987654",</span><br><span style="color: hsl(120, 100%, 40%);">+               .mi_name = "IMEI-SV-9876543210987654",</span><br><span style="color: hsl(120, 100%, 40%);">+              .expect_mi_tlv_hex = "17099378563412907856f4",</span><br><span>     },</span><br><span>   {</span><br><span>            .mi_type = GSM_MI_TYPE_IMEISV,</span><br><span style="color: hsl(0, 100%, 40%);">-          .mi_str = "987654321098765432",</span><br><span style="color: hsl(0, 100%, 40%);">-               .mi_name = "IMEI-SV-987654321098765432",</span><br><span style="color: hsl(0, 100%, 40%);">-              .expect_mi_tlv_hex = "170a937856341290785634f2",</span><br><span style="color: hsl(0, 100%, 40%);">-              .str_size = 16,</span><br><span style="color: hsl(0, 100%, 40%);">-         .expect_str = "987654321098765",</span><br><span style="color: hsl(120, 100%, 40%);">+            .mi_str = "9876543210987654",</span><br><span style="color: hsl(120, 100%, 40%);">+               .mi_name = "IMEI-SV-9876543210987654",</span><br><span style="color: hsl(120, 100%, 40%);">+              .expect_mi_tlv_hex = "17099378563412907856f4",</span><br><span style="color: hsl(120, 100%, 40%);">+              .str_size = 17,</span><br><span style="color: hsl(120, 100%, 40%);">+               .expect_str = "9876543210987654",</span><br><span>  },</span><br><span>   {</span><br><span>            /* gsm48 treats TMSI as decimal string */</span><br><span>diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok</span><br><span>index 8f6630b..0bd101d 100644</span><br><span>--- a/tests/gsm0408/gsm0408_test.ok</span><br><span>+++ b/tests/gsm0408/gsm0408_test.ok</span><br><span>@@ -40,14 +40,14 @@</span><br><span>   -> MI-TLV-hex='17089a78563412907856'</span><br><span>   -> MI-str="987654321098765" rc=16</span><br><span>   -> MI-name="IMEI-987654321098765"</span><br><span style="color: hsl(0, 100%, 40%);">-- IMEI-SV 987654321098765432</span><br><span style="color: hsl(0, 100%, 40%);">-  -> MI-TLV-hex='170a937856341290785634f2'</span><br><span style="color: hsl(0, 100%, 40%);">-  -> MI-str="987654321098765432" rc=19</span><br><span style="color: hsl(0, 100%, 40%);">-  -> MI-name="IMEI-SV-987654321098765432"</span><br><span style="color: hsl(0, 100%, 40%);">-- IMEI-SV 987654321098765432</span><br><span style="color: hsl(0, 100%, 40%);">-  -> MI-TLV-hex='170a937856341290785634f2'</span><br><span style="color: hsl(0, 100%, 40%);">-  -> MI-str="987654321098765" rc=16</span><br><span style="color: hsl(0, 100%, 40%);">-  -> MI-name="IMEI-SV-987654321098765432"</span><br><span style="color: hsl(120, 100%, 40%);">+- IMEI-SV 9876543210987654</span><br><span style="color: hsl(120, 100%, 40%);">+  -> MI-TLV-hex='17099378563412907856f4'</span><br><span style="color: hsl(120, 100%, 40%);">+  -> MI-str="9876543210987654" rc=17</span><br><span style="color: hsl(120, 100%, 40%);">+  -> MI-name="IMEI-SV-9876543210987654"</span><br><span style="color: hsl(120, 100%, 40%);">+- IMEI-SV 9876543210987654</span><br><span style="color: hsl(120, 100%, 40%);">+  -> MI-TLV-hex='17099378563412907856f4'</span><br><span style="color: hsl(120, 100%, 40%);">+  -> MI-str="9876543210987654" rc=17</span><br><span style="color: hsl(120, 100%, 40%);">+  -> MI-name="IMEI-SV-9876543210987654"</span><br><span> - TMSI 305419896</span><br><span>   -> MI-TLV-hex='1705f412345678'</span><br><span>   -> MI-str="305419896" rc=9</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12642">change 12642</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12642"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6fb85a0516dc387902ad9de4fe8c1ba82d68cae6 </div>
<div style="display:none"> Gerrit-Change-Number: 12642 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>