<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12645">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized<br><br>This fixes the following compiler warning when using -Werror on gcc-8.2:<br><br>sccp.c: In function ‘sccp_system_incoming_ctx’:<br>sccp.c:1039:10: error: ‘result.destination_local_reference’ may be used uninitialized in this function [-Werror=maybe-uninitialized]<br>       && memcmp(&conn->source_local_reference,<br>          result.destination_local_reference,<br>          sizeof(conn->source_local_reference)) == 0<br>sccp.c:1030:27: note: ‘result.destination_local_reference’ was declared here<br>  struct sccp_parse_result result;<br>                           ^~~~~~<br><br>Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490<br>---<br>M src/sccp.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sccp.c b/src/sccp.c</span><br><span>index 8c3641c..ec0f3b7 100644</span><br><span>--- a/src/sccp.c</span><br><span>+++ b/src/sccp.c</span><br><span>@@ -1027,7 +1027,7 @@</span><br><span> /* Handle the release confirmed */</span><br><span> static int _sccp_handle_connection_release_complete(struct msgb *msgb)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      struct sccp_parse_result result;</span><br><span style="color: hsl(120, 100%, 40%);">+      struct sccp_parse_result result = {};</span><br><span>        struct sccp_connection *conn;</span><br><span> </span><br><span>    if (_sccp_parse_connection_release_complete(msgb, &result) != 0)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12645">change 12645</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12645"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490 </div>
<div style="display:none"> Gerrit-Change-Number: 12645 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>