<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12615">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Log transaction allocation errors as such<br><br>While at it, use proper subsystem to log missing VLR subscriber.<br><br>Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9<br>---<br>M src/libmsc/gsm_04_08_cc.c<br>M src/libmsc/gsm_09_11.c<br>M src/libmsc/transaction.c<br>3 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/15/12615/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c</span><br><span>index 7172184..0119e7b 100644</span><br><span>--- a/src/libmsc/gsm_04_08_cc.c</span><br><span>+++ b/src/libmsc/gsm_04_08_cc.c</span><br><span>@@ -1931,7 +1931,7 @@</span><br><span>           /* Create transaction */</span><br><span>             trans = trans_alloc(net, vsub, GSM48_PDISC_CC, 0xff, data->callref);</span><br><span>              if (!trans) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   DEBUGP(DCC, "No memory for trans.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DCC, LOGL_ERROR, "No memory for trans.\n");</span><br><span>                   vlr_subscr_put(vsub);</span><br><span>                        /* Ressource unavailable */</span><br><span>                  mncc_release_ind(net, NULL, data->callref,</span><br><span>@@ -2129,7 +2129,7 @@</span><br><span>                                    GSM48_PDISC_CC,</span><br><span>                              transaction_id, new_callref++);</span><br><span>          if (!trans) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   DEBUGP(DCC, "No memory for trans.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DCC, LOGL_ERROR, "No memory for trans.\n");</span><br><span>                   rc = gsm48_tx_simple(conn,</span><br><span>                                        GSM48_PDISC_CC | (transaction_id << 4),</span><br><span>                                        GSM48_MT_CC_RELEASE_COMPL);</span><br><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index 12bec9d..608d4ff 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -101,7 +101,7 @@</span><br><span>          trans = trans_alloc(conn->network, conn->vsub,</span><br><span>                                     GSM48_PDISC_NC_SS, tid, new_callref++);</span><br><span>          if (!trans) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   DEBUGP(DMM, " -> No memory for trans\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                        LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n");</span><br><span>                     gsm48_tx_simple(conn,</span><br><span>                                GSM48_PDISC_NC_SS | (tid << 4),</span><br><span>                                GSM0480_MTYPE_RELEASE_COMPLETE);</span><br><span>@@ -298,7 +298,7 @@</span><br><span>       trans = trans_alloc(net, vsub, GSM48_PDISC_NC_SS,</span><br><span>            0xff, gsup_msg->session_id);</span><br><span>      if (!trans) {</span><br><span style="color: hsl(0, 100%, 40%);">-           DEBUGP(DMM, " -> No memory for trans\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n");</span><br><span>             return NULL;</span><br><span>         }</span><br><span> </span><br><span>diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c</span><br><span>index df770ed..17f8e96 100644</span><br><span>--- a/src/libmsc/transaction.c</span><br><span>+++ b/src/libmsc/transaction.c</span><br><span>@@ -109,7 +109,7 @@</span><br><span> </span><br><span>         /* a valid subscriber is indispensable */</span><br><span>    if (vsub == NULL) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGP(DCC, LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DVLR, LOGL_ERROR,</span><br><span>                    "unable to alloc transaction, invalid subscriber (NULL)\n");</span><br><span>          return NULL;</span><br><span>         }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12615">change 12615</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12615"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9 </div>
<div style="display:none"> Gerrit-Change-Number: 12615 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>