<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12623">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan_select: Do not unsolicitedly select a TCH/F<br><br>The function lchan_select_by_type() will unsolicitedly select a TCH/F<br>when it is asked for a TCH/H but a TCH/H is not available. This behavior<br>is presumably a leftover from before the split. Now every fallback to<br>another rate must be agreed with the MSC in advance, it is a spec<br>violation to silently fallback to TCH/F when asked for a TCH/H.<br><br>Change-Id: I057e70bc81b3dac470f6d1d2a37533ec3a7a79d0<br>Related: OS#3503<br>---<br>M src/osmo-bsc/lchan_select.c<br>1 file changed, 0 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/23/12623/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c</span><br><span>index 0e22448..eac0adf 100644</span><br><span>--- a/src/osmo-bsc/lchan_select.c</span><br><span>+++ b/src/osmo-bsc/lchan_select.c</span><br><span>@@ -206,12 +206,6 @@</span><br><span>                 break;</span><br><span>       case GSM_LCHAN_TCH_H:</span><br><span>                lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_H);</span><br><span style="color: hsl(0, 100%, 40%);">-             /* If we don't have TCH/H available, fall-back to TCH/F */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (!lchan) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_F);</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-                              type = GSM_LCHAN_TCH_F;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span>            /* No dedicated TCH/x available -- try fully dynamic</span><br><span>                  * TCH/F_TCH/H_PDCH */</span><br><span>               if (!lchan) {</span><br><span>@@ -221,17 +215,6 @@</span><br><span>                         if (lchan)</span><br><span>                           type = GSM_LCHAN_TCH_H;</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-               /*</span><br><span style="color: hsl(0, 100%, 40%);">-               * No need to check TCH/F_TCH/H_PDCH channels for TCH/F:</span><br><span style="color: hsl(0, 100%, 40%);">-                 * if no TCH/H was available, neither will be TCH/F.</span><br><span style="color: hsl(0, 100%, 40%);">-             */</span><br><span style="color: hsl(0, 100%, 40%);">-             /* If we don't have TCH/F either, try dynamic TCH/F_PDCH */</span><br><span style="color: hsl(0, 100%, 40%);">-         if (!lchan) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   lchan = _lc_dyn_find_bts(bts, GSM_PCHAN_TCH_F_PDCH,</span><br><span style="color: hsl(0, 100%, 40%);">-                                              GSM_PCHAN_TCH_F);</span><br><span style="color: hsl(0, 100%, 40%);">-                      if (lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-                              type = GSM_LCHAN_TCH_F;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span>            break;</span><br><span>       default:</span><br><span>             LOGP(DRLL, LOGL_ERROR, "Unknown gsm_chan_t %u\n", type);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12623">change 12623</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12623"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I057e70bc81b3dac470f6d1d2a37533ec3a7a79d0 </div>
<div style="display:none"> Gerrit-Change-Number: 12623 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>