<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12588">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/trx_if.c: check if trx_fsm allocation failed<br><br>Change-Id: I31c9f2a651182b258d0a4d4504365b778529715a<br>---<br>M src/host/trxcon/trx_if.c<br>1 file changed, 11 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/88/12588/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c</span><br><span>index 5fe5000..f2db145 100644</span><br><span>--- a/src/host/trxcon/trx_if.c</span><br><span>+++ b/src/host/trxcon/trx_if.c</span><br><span>@@ -642,6 +642,16 @@</span><br><span>           return NULL;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Allocate a new dedicated state machine */</span><br><span style="color: hsl(120, 100%, 40%);">+  trx->fsm = osmo_fsm_inst_alloc(&trx_fsm, trx,</span><br><span style="color: hsl(120, 100%, 40%);">+          NULL, LOGL_DEBUG, "trx_interface");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (trx->fsm == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DTRX, LOGL_ERROR, "Failed to allocate an instance "</span><br><span style="color: hsl(120, 100%, 40%);">+                    "of FSM '%s'\n", trx_fsm.name);</span><br><span style="color: hsl(120, 100%, 40%);">+             talloc_free(trx);</span><br><span style="color: hsl(120, 100%, 40%);">+             return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* Initialize CTRL queue */</span><br><span>  INIT_LLIST_HEAD(&trx->trx_ctrl_list);</span><br><span> </span><br><span>@@ -656,14 +666,11 @@</span><br><span>     if (rc < 0)</span><br><span>               goto udp_error;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     /* Allocate a new dedicated state machine */</span><br><span style="color: hsl(0, 100%, 40%);">-    trx->fsm = osmo_fsm_inst_alloc(&trx_fsm, trx,</span><br><span style="color: hsl(0, 100%, 40%);">-            NULL, LOGL_DEBUG, "trx_interface");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        return trx;</span><br><span> </span><br><span> udp_error:</span><br><span>        LOGP(DTRX, LOGL_ERROR, "Couldn't establish UDP connection\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  osmo_fsm_inst_free(trx->fsm);</span><br><span>     talloc_free(trx);</span><br><span>    return NULL;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12588">change 12588</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12588"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I31c9f2a651182b258d0a4d4504365b778529715a </div>
<div style="display:none"> Gerrit-Change-Number: 12588 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>