<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12596">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Log MDCX ACK for established lchan<br><br>Previously LCHAN_RTP_EV_IPACC_MDCX_ACK was not permitted for<br>LCHAN_RTP_ST_ESTABLISHED state in lchan FSM. However this message is<br>normal in case of LCLS loop closed via IPA (as opposed to MGCP). Let's<br>permit this message and log it to make debug output easier to read.<br><br>Change-Id: Ib642df799f3405c4d707eb57b2ebc84386d7f03f<br>Related: OS#2487<br>---<br>M src/osmo-bsc/lchan_rtp_fsm.c<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/12596/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c</span><br><span>index 84cc287..2d15bf2 100644</span><br><span>--- a/src/osmo-bsc/lchan_rtp_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_rtp_fsm.c</span><br><span>@@ -565,13 +565,19 @@</span><br><span> </span><br><span> static void lchan_rtp_fsm_established(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+       struct gsm_lchan *lchan = lchan_rtp_fi_lchan(fi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  switch (event) {</span><br><span> </span><br><span>         case LCHAN_RTP_EV_RELEASE:</span><br><span>   case LCHAN_RTP_EV_ROLLBACK:</span><br><span>          osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, 0);</span><br><span>            return;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+       case LCHAN_RTP_EV_IPACC_MDCX_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+             LOG_LCHAN_RTP(lchan, LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                           "Received MDCX ACK on established lchan's RTP port: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                              mgwep_ci_name(lchan->mgw_endpoint_ci_bts));</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span>      default:</span><br><span>             OSMO_ASSERT(false);</span><br><span>  }</span><br><span>@@ -689,6 +695,7 @@</span><br><span>              .in_event_mask = 0</span><br><span>                   | S(LCHAN_RTP_EV_RELEASE)</span><br><span>                    | S(LCHAN_RTP_EV_ROLLBACK)</span><br><span style="color: hsl(120, 100%, 40%);">+                    | S(LCHAN_RTP_EV_IPACC_MDCX_ACK)</span><br><span>                     ,</span><br><span>    },</span><br><span>   [LCHAN_RTP_ST_ROLLBACK] = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12596">change 12596</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12596"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib642df799f3405c4d707eb57b2ebc84386d7f03f </div>
<div style="display:none"> Gerrit-Change-Number: 12596 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>