<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11924">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_Tests.ttcn: introduce TC_gsup_mt_sms_{ack|err}<br><br>The idea of this test case is to verify MT SMS transmission<br>initiated by ESME over GSUP. Basically, the algorythm is<br>the following:<br><br> 1.0 send MT-ForwardSM-Req on GSUP,<br> 1.1 expect Paging Request on RAN,<br> 1.2 establish a RAN connection,<br> 1.3 expect CP-DATA/RP-DATA on BSSAP/DTAP,<br> 2.1 send CP-DATA/RP-ACK on BSSAP/DTAP,<br> 2.2.a expect MT-ForwardSM-Res,<br> 2.2.b expect MT-ForwardSM-Err.<br><br>Change-Id: I63a25c8366cce0852df6b628365151661a22a25f<br>Related: OS#3587<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/expected-results.xml<br>2 files changed, 151 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 96ddc8d..b7a02a7 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -2196,6 +2196,153 @@</span><br><span> f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Helper for sending MT SMS over GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_gsup_forwardSM_req(SmsParameters spars, OCT1 mms := '00'O)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP.send(ts_GSUP_MT_FORWARD_SM_REQ(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* NOTE: MSC should assign RP-MR itself */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := 'FF'O,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: extract SM-RP-DA from spars.rp.dest */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: fix encoding of ts_GSUP_SM_RP_DA_IMSI */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_da := valueof(ts_GSUP_SM_RP_DA_MSISDN(g_pars.msisdn)),</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_oa := valueof(ts_GSUP_SM_RP_OA_SMSC_ADDR(g_pars.msisdn)),</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Encoded SMS TPDU (taken from Wireshark)</span><br><span style="color: hsl(120, 100%, 40%);">+ * FIXME: we should encode spars somehow */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_ui := '00068021436500008111328130858200'O,</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mms := mms</span><br><span style="color: hsl(120, 100%, 40%);">+ ));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Test successful MT-SMS (RP-ACK) over GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_gsup_mt_sms_ack(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SmsParameters spars := valueof(t_SmsPars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We need to inspect GSUP activity */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Perform location update */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Register an 'expect' for given IMSI (+TMSI) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (isvalue(g_pars.tmsi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, g_pars.tmsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, 'FFFFFFFF'O);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var template GSUP_PDU mt_forwardSM_res := tr_GSUP_MT_FORWARD_SM_RES(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* NOTE: MSC should assign RP-MR itself */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := ?</span><br><span style="color: hsl(120, 100%, 40%);">+ );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Submit a MT SMS on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gsup_forwardSM_req(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect Paging Request and Establish DTAP / BSSAP / SCCP connection */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(EST_TYPE_PAG_RESP);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait for MT SMS on DTAP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_expect(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send RP-ACK and expect MT-forwardSM-Res on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_send_rp_ack(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive(mt_forwardSM_res) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX MT-forwardSM-Res (RP-ACK)");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX unexpected GSUP message");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_gsup_mt_sms_ack() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := f_init_pars(90);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler_with_pars(refers(f_tc_gsup_mt_sms_ack), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Test rejected MT-SMS (RP-ERROR) over GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_gsup_mt_sms_err(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SmsParameters spars := valueof(t_SmsPars);</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT1 sm_rp_cause := '78'O; /* dummy RP-Cause value */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We need to inspect GSUP activity */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Perform location update */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Register an 'expect' for given IMSI (+TMSI) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (isvalue(g_pars.tmsi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, g_pars.tmsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, 'FFFFFFFF'O);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var template GSUP_PDU mt_forwardSM_err := tr_GSUP_MT_FORWARD_SM_ERR(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* NOTE: MSC should assign RP-MR itself */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_cause := sm_rp_cause</span><br><span style="color: hsl(120, 100%, 40%);">+ );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Submit a MT SMS on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gsup_forwardSM_req(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect Paging Request and Establish DTAP / BSSAP / SCCP connection */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(EST_TYPE_PAG_RESP);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait for MT SMS on DTAP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_expect(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send RP-ERROR and expect MT-forwardSM-Err on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_send_rp_error(spars, oct2int(sm_rp_cause));</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive(mt_forwardSM_err) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX MT-forwardSM-Err (RP-ERROR)");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX unexpected GSUP message");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_gsup_mt_sms_err() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := f_init_pars(91);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler_with_pars(refers(f_tc_gsup_mt_sms_err), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* convert GSM L3 TON to SMPP_TON enum */</span><br><span> function f_sm_ton_from_gsm(BIT3 ton) return SMPP_TON {</span><br><span> select (ton) {</span><br><span>@@ -4057,6 +4204,8 @@</span><br><span> </span><br><span> execute( TC_gsup_mo_sms() );</span><br><span> execute( TC_gsup_mo_smma() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_gsup_mt_sms_ack() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_gsup_mt_sms_err() );</span><br><span> </span><br><span> execute( TC_lu_and_mo_ussd_single_request() );</span><br><span> execute( TC_lu_and_mt_ussd_notification() );</span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index 8a5822d..7a35296 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -65,6 +65,8 @@</span><br><span> <testcase classname='MSC_Tests' name='TC_smpp_mt_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mo_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mo_smma' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_ack' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_err' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_single_request' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mt_ussd_notification' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_during_mt_call' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11924">change 11924</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11924"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I63a25c8366cce0852df6b628365151661a22a25f </div>
<div style="display:none"> Gerrit-Change-Number: 11924 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Holger Freyther <holger@freyther.de> </div>