<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12058">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Max: Looks good to me, approved
Harald Welte: Looks good to me, approved
Stefan Sperling: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms<br><br>The idea of this test case is to verify the process of multi-part<br>MT SMS transmission. The MSC should keep the RAN connection until<br>the last message part is transmitted.<br><br>Change-Id: I6308586a70c4fb3254c519330a61a9667372149f<br>Related: OS#3587<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/expected-results.xml<br>2 files changed, 73 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index b7a02a7..05f8fd9 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -2343,6 +2343,77 @@</span><br><span> f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test multi-part MT-SMS over GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_gsup_mt_multi_part_sms(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SmsParameters spars := valueof(t_SmsPars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We need to inspect GSUP activity */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Perform location update */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Register an 'expect' for given IMSI (+TMSI) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (isvalue(g_pars.tmsi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, g_pars.tmsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssmap_register_imsi(g_pars.imsi, 'FFFFFFFF'O);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var template GSUP_PDU mt_forwardSM_res := tr_GSUP_MT_FORWARD_SM_RES(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* NOTE: MSC should assign RP-MR itself */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := ?</span><br><span style="color: hsl(120, 100%, 40%);">+ );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send 4 messages (NOTE: SM-RP-UI remains unchanged) */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 3; i >= 0; i := i-1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Submit a MT SMS on GSUP (MMS is decremented) */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gsup_forwardSM_req(spars, int2oct(i, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect Paging Request and Establish connection */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (i == 3) { /* ... only once! */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(EST_TYPE_PAG_RESP);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait for MT SMS on DTAP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_expect(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send RP-ACK and expect MT-forwardSM-Res on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mt_sms_send_rp_ack(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive(mt_forwardSM_res) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX MT-forwardSM-Res (RP-ACK)");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX unexpected GSUP message");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Keep some 'distance' between transmissions */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(1.5);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_gsup_mt_multi_part_sms() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := f_init_pars(91);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler_with_pars(refers(f_tc_gsup_mt_multi_part_sms), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* convert GSM L3 TON to SMPP_TON enum */</span><br><span> function f_sm_ton_from_gsm(BIT3 ton) return SMPP_TON {</span><br><span> select (ton) {</span><br><span>@@ -4206,6 +4277,7 @@</span><br><span> execute( TC_gsup_mo_smma() );</span><br><span> execute( TC_gsup_mt_sms_ack() );</span><br><span> execute( TC_gsup_mt_sms_err() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_gsup_mt_multi_part_sms() );</span><br><span> </span><br><span> execute( TC_lu_and_mo_ussd_single_request() );</span><br><span> execute( TC_lu_and_mt_ussd_notification() );</span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index 7a35296..8a19d5b 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -67,6 +67,7 @@</span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mo_smma' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_ack' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_err' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_gsup_mt_multi_part_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_single_request' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mt_ussd_notification' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_during_mt_call' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12058">change 12058</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12058"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6308586a70c4fb3254c519330a61a9667372149f </div>
<div style="display:none"> Gerrit-Change-Number: 12058 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>