<p style="white-space: pre-wrap; word-wrap: break-word;">Looks fine, just a few cosmetic issues.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/12415">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12415/1/Transceiver52M/arch/common/convolve_base.c">File Transceiver52M/arch/common/convolve_base.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12415/1/Transceiver52M/arch/common/convolve_base.c@46">Patch Set #1, Line 46:</a> <code style="font-family:monospace,monospace">for (int i=0; i<len; i++)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Usually all arithmetic operators are space-separated.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12415/1/tests/Transceiver52M/convolve_test.c">File tests/Transceiver52M/convolve_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12415/1/tests/Transceiver52M/convolve_test.c@93">Patch Set #1, Line 93:</a> <code style="font-family:monospace,monospace">x-30,2*x_len+30</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12415/1/tests/Transceiver52M/convolve_test.c@95">Patch Set #1, Line 95:</a> <code style="font-family:monospace,monospace">2*h_len</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">and here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12415">change 12415</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12415"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic850269a0ed5d98c0ea68980afd31016ed555b48 </div>
<div style="display:none"> Gerrit-Change-Number: 12415 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 09 Jan 2019 02:53:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>