<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12481">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_04_08: Fix nullpointer deref<br><br>The pointers conn, conn->vsub and conn->vsub->last_tuple are checked,<br>but before the check those pointers are already dereferenced during<br>assignment. This defeats the purpose of the check. Lets dereference<br>those pointers after the check.<br><br>Fixes: CID#190404<br>Change-Id: Ice4992606f3799eac13154ec0b9f53e46d2e178e<br>---<br>M src/libmsc/gsm_04_08.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/81/12481/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c</span><br><span>index 7ff8681..d45de16 100644</span><br><span>--- a/src/libmsc/gsm_04_08.c</span><br><span>+++ b/src/libmsc/gsm_04_08.c</span><br><span>@@ -1596,12 +1596,12 @@</span><br><span> </span><br><span> int ran_conn_geran_set_cipher_mode(struct ran_conn *conn, bool umts_aka, bool retrieve_imeisv)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm_network *net = conn->network;</span><br><span style="color: hsl(120, 100%, 40%);">+   struct gsm_network *net;</span><br><span>     struct gsm0808_encrypt_info ei;</span><br><span>      int i, j = 0;</span><br><span>        int request_classmark = 0;</span><br><span>   int request_classmark_for_a5_n = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-     struct vlr_auth_tuple *tuple = conn->vsub->last_tuple;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct vlr_auth_tuple *tuple;</span><br><span> </span><br><span>    if (!conn || !conn->vsub || !conn->vsub->last_tuple) {</span><br><span>              /* This should really never happen, because we checked this in msc_vlr_set_ciph_mode()</span><br><span>@@ -1610,6 +1610,9 @@</span><br><span>               return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ net = conn->network;</span><br><span style="color: hsl(120, 100%, 40%);">+        tuple = conn->vsub->last_tuple;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     for (i = 0; i < 8; i++) {</span><br><span>                 int supported;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12481">change 12481</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12481"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ice4992606f3799eac13154ec0b9f53e46d2e178e </div>
<div style="display:none"> Gerrit-Change-Number: 12481 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>