<p><a href="https://gerrit.osmocom.org/12416">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c">File tests/Transceiver52M/convolve_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c@106">Patch Set #4, Line 106:</a> <code style="font-family:monospace,monospace">      enum {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You could make this enum named (move it out of struct test_data) and then use it as parameter in run_convolve to make parameter "int test" easier to read and understand.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c@226">Patch Set #4, Line 226:</a> <code style="font-family:monospace,monospace">     case CONV_REAL_OPT:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing break? Otherwise add /* fall through */</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c@233">Patch Set #4, Line 233:</a> <code style="font-family:monospace,monospace">    case CONV_COMPLEX_BASE:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing break? Otherwise add /* fall through */</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12416">change 12416</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12416"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4e203d2c4b778af77d630ed15d4cef6b0c0eb76d </div>
<div style="display:none"> Gerrit-Change-Number: 12416 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 08 Jan 2019 17:46:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>