<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12378">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">LCLS: use enum values instead of magic numbers<br><br>Change-Id: I3f49f74edb5400df1b13bb75da3d524f234c8d03<br>Related: OS#3659<br>---<br>M src/osmo-bsc/osmo_bsc_lcls.c<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>index 26b3244..2d5a077 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>@@ -50,11 +50,11 @@</span><br><span> enum gsm0808_lcls_status lcls_get_status(struct gsm_subscriber_connection *conn)</span><br><span> {</span><br><span>  if (!conn->lcls.fi)</span><br><span style="color: hsl(0, 100%, 40%);">-          return 0xff;</span><br><span style="color: hsl(120, 100%, 40%);">+          return GSM0808_LCLS_STS_NA;</span><br><span> </span><br><span>      switch (conn->lcls.fi->state) {</span><br><span>        case ST_NO_LCLS:</span><br><span style="color: hsl(0, 100%, 40%);">-                return 0xff;</span><br><span style="color: hsl(120, 100%, 40%);">+          return GSM0808_LCLS_STS_NA;</span><br><span>  case ST_NOT_YET_LS:</span><br><span>          return GSM0808_LCLS_STS_NOT_YET_LS;</span><br><span>  case ST_NOT_POSSIBLE_LS:</span><br><span>@@ -76,7 +76,7 @@</span><br><span>         enum gsm0808_lcls_status status = lcls_get_status(conn);</span><br><span>     struct msgb *msg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (status == 0xff)</span><br><span style="color: hsl(120, 100%, 40%);">+   if (status == GSM0808_LCLS_STS_NA)</span><br><span>           return;</span><br><span> </span><br><span>  LOGPFSM(conn->lcls.fi, "Sending BSSMAP LCLS NOTIFICATION (%s)\n",</span><br><span>@@ -384,7 +384,7 @@</span><br><span>                         return;</span><br><span>              return;</span><br><span>      case LCLS_EV_APPLY_CFG_CSC:</span><br><span style="color: hsl(0, 100%, 40%);">-             if (conn->lcls.config == 0xff)</span><br><span style="color: hsl(120, 100%, 40%);">+             if (conn->lcls.config == GSM0808_LCLS_CFG_NA)</span><br><span>                     return;</span><br><span>              if (lcls_perform_correlation(conn) != 0) {</span><br><span>                   /* Correlation leads to no result: Not Possible to LS */</span><br><span>@@ -887,7 +887,7 @@</span><br><span> void bssmap_add_lcls_status_if_needed(struct gsm_subscriber_connection *conn, struct msgb *msg)</span><br><span> {</span><br><span>       enum gsm0808_lcls_status status = lcls_get_status(conn);</span><br><span style="color: hsl(0, 100%, 40%);">-        if (status != 0xff) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (status != GSM0808_LCLS_STS_NA) {</span><br><span>                 LOGPFSM(conn->fi, "Adding LCLS BSS-Status (%s) to %s\n",</span><br><span>                        gsm0808_lcls_status_name(status),</span><br><span>                    gsm0808_bssmap_name(msg->l3h[2]));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12378">change 12378</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12378"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3f49f74edb5400df1b13bb75da3d524f234c8d03 </div>
<div style="display:none"> Gerrit-Change-Number: 12378 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>